This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Customizable print header #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfiguration screen
…rontend into customizable-print-header
jkleinsc
suggested changes
Mar 13, 2017
There was a problem hiding this comment.
Looks good to me @baoqchau. Thanks for the PR.
I'm not sure that we need the checkboxes to include fields, but I guess it doesn't hurt to have them.
The only thing I think that needs to be done is to add an acceptance test for the screen. Can you add a test to https://github.com/HospitalRun/hospitalrun-frontend/blob/master/tests/acceptance/admin-test.js?
You can copy the test for address options and modify the copy to test your screen:
https://github.com/HospitalRun/hospitalrun-frontend/blob/master/tests/acceptance/admin-test.js#L82-L98
jkleinsc
approved these changes
Mar 13, 2017
|
Looks good to me. Thanks for the update @baoqchau! I'll merge it in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #790
Changes proposed in this pull request:
cc @jkleinsc