This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Added a calendar that displays appointments (WIP) #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To confirm basic appointment -> event conversion works.
# Conflicts: # app/appointments/search/controller.js # package.json
# Conflicts: # package.json
As this progresses I'll try to get a live view of my branch going on some server somewhere. It's a fairly large addition and I feel screenshots/videos/gifs aren't that helpful for seeing how it works. |
jkleinsc
added
the
in progress
indicates that issue/pull request is currently being worked on
label
Nov 28, 2016
@BogdanAlexandru thanks for the update! |
@BogdanAlexandru I need to move this feature along. If you aren't working on it, I'd like to take what you have and continue working on it myself. |
I'm unable to work right now and won't be for the near future, taking over sounds like the way to go. The calendar-view branch has all of my latest changes, nothing on local needs pushing. Sorry for the late notice on this. |
Merging existing PR into calendar branch so I can continue the work that @BogdanAlexandru started. Thanks @BogdanAlexandru for your efforts! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #760
Changes proposed in this pull request:
cc @HospitalRun/core-maintainers
This is still WIP. Stuff that still needs to be done:
// To cater for times like 0:00 - investigate.
Things that I don't like very much include the redundant first query for the model the calendar route performs. The idea there is a bit backwards, so I'm not sure how to avoid it. The model to load is indicated by the calendar control, but you need a loaded route to get the calendar control, so you always have two loads. When returning from an appointment, it will do the first redundant load, then reset the calendar to the passed in view config, then reload.
Throw all your critique my way 👍