This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Removes unnecessary resetNamespaces
#821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The routes declared directly beneath `Router.map` are already top-level, so the reset is unnecessary. This has the added benefit of removing some visual cruft, because the few `resetNamespace`s left are actually meaningful, making visual parsing easier, as well as grepping.
jkleinsc
suggested changes
Nov 30, 2016
| this.route('users', { | ||
| resetNamespace: true | ||
| }, function() { | ||
| this.route('users', function() { |
There was a problem hiding this comment.
This change is causing tests to fail because users sits at /app/users, not /app/admin/users
|
@jkleinsc oops, I think I misread the indentation! Do you want me to squash the commits as well? |
|
@locks I can squish the commits via GithHub, so you don't need to worry about that. |
jkleinsc
approved these changes
Nov 30, 2016
|
Thanks @locks! I'll merge it in. |
|
Thanks :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a code style improvement with no issue associated.
Changes proposed in this pull request:
{ resetNamespace: true }for top-level routes.cc @HospitalRun/core-maintainers
The routes declared directly beneath
Router.mapare already top-level, so the reset is unnecessary.This has the added benefit of removing some visual cruft, because the few
resetNamespaces left are actually meaningful, making visual parsing easier, as well as grepping.