adding readme on start coding #521
Conversation
|
Thanks @morsh. @HospitalRun/core-maintainers what do you think of this PR? |
|
This is fantastic. 👏 ✨ Haven't had a chance to really dig into the content yet, but only feedback at a glance is where it should live. I think this should probably be included as a section in the CONTRIBUTING.md file, rather than as a separate readme file. |
|
Hi @jglovier |
|
@morsh I think the information is still relevant, but it needs to be placed here https://github.com/hospitalrun/hospitalrun-frontend/blob/master/.github/CONTRIBUTING.md instead of in its own file |
|
Hi @jkleinsc, |
|
|
||
| ## Start Coding | ||
|
|
||
| Thissection is designed to help developers start coding in the project and understanding the basic concepts and components used. |
There was a problem hiding this comment.
Needs space between "This" and "section"
|
|
||
| ### Ember | ||
|
|
||
| To understand the project you'll have to understand Ember, and it is advisable that you'll follow the tutorial: [Create your own app](https://guides.emberjs.com/v2.6.0/tutorial/ember-cli/) to get an understanding of how ember works and the basic folder structure. |
There was a problem hiding this comment.
The tutorial guide url should be updated to:
https://guides.emberjs.com/v2.9.0/tutorial/ember-cli/
|
@jkleinsc - done |
|
Thanks @morsh! I'll merge it in. |
I've added a readme on how to start coding.