Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(labs): updates successfully completed message #2385

Merged
merged 4 commits into from
Sep 10, 2020

Conversation

gaweki
Copy link
Contributor

@gaweki gaweki commented Sep 9, 2020

Fixes #2295

Fixes button text view lab.

Changes proposed in this pull request:

  • Add successfullyCompleted to enUs translations

Newly added dependencies with Bundlephobia links:

NONE

@gitpod-io
Copy link

gitpod-io bot commented Sep 9, 2020

@gaweki gaweki changed the title fix: add successfullycompleted resolves #2295 fix(labs): add successfullycompleted resolves #2295 Sep 9, 2020
@vercel
Copy link

vercel bot commented Sep 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/203yjmj5p
✅ Preview: https://hospitalrun-frontend-git-fork-gaweki-translations.hospitalrun.vercel.app

@gaweki
Copy link
Contributor Author

gaweki commented Sep 9, 2020

hello @jackcmeyer, please review

@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Sep 9, 2020
@blestab blestab added this to the v2.0 milestone Sep 9, 2020
@blestab blestab added the labs issue/pull request that interacts with labs module label Sep 9, 2020
Copy link
Contributor

@blestab blestab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May you correct the spelling for successfully and use lowercase c in the word completed to keep the message consistent with other messages i.e. your message must be changed to "Successfully completed"

Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue describes the expected message to be:

The message should say Successfully completed ${type} for ${patient}

Currently the message says Successfully completed ${type} ${patient}

@jackcmeyer jackcmeyer changed the title fix(labs): add successfullycompleted resolves #2295 fix(labs): updates successfully completed message Sep 10, 2020
@gaweki
Copy link
Contributor Author

gaweki commented Sep 10, 2020

The issue describes the expected message to be:

The message should say Successfully completed ${type} for ${patient}

Currently the message says Successfully completed ${type} ${patient}

okey i will update it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on labs issue/pull request that interacts with labs module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Successfully completed lab shows translation key instead of actual text
5 participants