Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(eslint rule and subsequent changes to the codebase): eslint rule no-console added #2319

Merged
merged 6 commits into from
Aug 20, 2020

Conversation

tobireuen
Copy link
Contributor

Fixes #2307

Changes proposed in this pull request:

  • add eslint rule 'no-console' to throw errors whenever calls to the console object are made
  • remove all calls to the console object OR allow them on file level for specific cases

Newly added dependencies with Bundlephobia links:

NONE

…no-console added

added eslint rule no-console to throw errors whenever calls to the console object are made and
subsequently removed all calls OR allowed them on file level for specific cases

fix HospitalRun#2307
@jsf-clabot
Copy link

jsf-clabot commented Aug 20, 2020

CLA assistant check
All committers have signed the CLA.

@gitpod-io
Copy link

gitpod-io bot commented Aug 20, 2020

@vercel
Copy link

vercel bot commented Aug 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/75ol956g3
✅ Preview: https://hospitalrun-frontend-git-fork-tobireuen-no-console.hospitalrun.vercel.app

@vercel vercel bot temporarily deployed to Preview August 20, 2020 10:07 Inactive
Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

couchdb-cleanup.sh Outdated Show resolved Hide resolved
couchdb-init.sh Outdated Show resolved Hide resolved
Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview August 20, 2020 10:47 Inactive
@matteovivona matteovivona merged commit bfb5bb7 into HospitalRun:master Aug 20, 2020
@tobireuen tobireuen deleted the no-console branch August 20, 2020 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow console log in ESLint
4 participants