Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(incidents): add loading during fetch phase #2085

Merged
merged 7 commits into from
May 20, 2020
Merged

fix(incidents): add loading during fetch phase #2085

merged 7 commits into from
May 20, 2020

Conversation

marcosvega91
Copy link
Contributor

fix #2081

Changes proposed in this pull request:

  • Added loading text until the incident if fetched

@gitpod-io
Copy link

gitpod-io bot commented May 17, 2020

@vercel
Copy link

vercel bot commented May 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/c6yb2e9ke
✅ Preview: https://hospitalrun-frontend-git-fork-marcosvega91-fix-viewincident.hospitalrun.now.sh

@jackcmeyer jackcmeyer added incidents patients issue/pull request that interacts with patients module 🚀enhancement an issue/pull request that adds a feature to the application labels May 17, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone May 17, 2020
@jackcmeyer jackcmeyer removed the patients issue/pull request that interacts with patients module label May 17, 2020
@matteovivona matteovivona changed the title fix(viewincident): add loading during fetch phase fix(incidents): add loading during fetch phase May 17, 2020
Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes requested.

src/incidents/view/ViewIncident.tsx Outdated Show resolved Hide resolved
</Row>
</>
)
if (incident) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a loading status as part of the incident slice that we should add into this check as well.

src/incidents/view/ViewIncident.tsx Outdated Show resolved Hide resolved
@jackcmeyer jackcmeyer merged commit d1fb940 into HospitalRun:master May 20, 2020
@marcosvega91 marcosvega91 deleted the fix/view_incident branch May 20, 2020 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application incidents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to view an incident
2 participants