Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(i18n): add French language #2013

Merged
merged 8 commits into from
Apr 25, 2020
Merged

feat(i18n): add French language #2013

merged 8 commits into from
Apr 25, 2020

Conversation

mleralec
Copy link
Contributor

@mleralec mleralec commented Apr 24, 2020 •
edited by gitpod-io bot
Loading

Fixes #1888

Changes proposed in this pull request:

  • Added folder fr/translations in src/locale folder
  • Added every translations keys from enUs folder
  • Added fr key on src/i18n file with the other available languages

@vercel
Copy link

vercel bot commented Apr 24, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/e8utrajmr
✅ Preview: https://hospitalrun-frontend-git-fork-mleralec-master.hospitalrun.now.sh

@vercel vercel bot temporarily deployed to Preview April 24, 2020 16:37 Inactive
@vercel vercel bot temporarily deployed to Preview April 24, 2020 16:38 Inactive
@matteovivona matteovivona changed the title feat(add french language): add French language feat(i18n): add French language Apr 24, 2020
@matteovivona matteovivona added in progress indicates that issue/pull request is currently being worked on localization labels Apr 24, 2020
@matteovivona matteovivona added this to the v2.0 milestone Apr 24, 2020
@gitpod-io
Copy link

gitpod-io bot commented Apr 24, 2020 •
edited
Loading

@vercel vercel bot temporarily deployed to Preview April 24, 2020 16:55 Inactive
fox1t
fox1t approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview April 24, 2020 17:01 Inactive
jackcmeyer
jackcmeyer approved these changes Apr 25, 2020
View reviewed changes
Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! But, I don't speak french

@matteovivona matteovivona merged commit fe60968 into HospitalRun:master Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fox1t fox1t fox1t approved these changes

@jackcmeyer jackcmeyer jackcmeyer approved these changes

@matteovivona matteovivona Awaiting requested review from matteovivona

Assignees
No one assigned
Labels
in progress indicates that issue/pull request is currently being worked on localization
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Add French language
4 participants
@mleralec @fox1t @jackcmeyer @matteovivona