feat(patients): max DOB set for current date

[jlato89]

Added maxDate prop to DatePicker component to avoid DOB being set in the future.

Fixes #1984.

Changes proposed in this pull request:

• Added maxDate prop to DatePickerWithLabelFormGroup component to restrict DOB from being set in the future.

Newly added dependencies with Bundlephobia links:

• No new dependencies

[jsf-clabot]

All committers have signed the CLA.

[vercel]

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/nrs0sriwn
✅ Preview: https://hospitalrun-frontend-git-fork-jlato89-master.hospitalrun.now.sh

[jlato89]

This also partially Fixes #1976 regarding the date of birth

[jackcmeyer]

Hi @jlato89!

Few changes requested:

• address comment
• add test to show that DatePickerWithLabelFormGroup passes maxDate value to DateTimePicker from @hospitalrun/components
• add test to show that GenrealInformation component sets the max date value to the current day

Please let me now if you need any help! Would love to work through this with you 👍

[jackcmeyer]

This component is intended to be more general than for use inside of the new/edit patient screen.

I think that this interface will only need to expose an optional maxDate and just pass it along to the DateTimePicker from @hopsitalrun/components`.

Then we'll need to make a change in the GenrealInformationComponent to set the maxDate property.

[fox1t]

I agree 100% with your vision. @jlato89 can you handle it?

[jlato89]

I should be able to yes. just an oversight on my part.

[fox1t]

I agree with @jackcmeyer on proposed changes.

[jlato89]

I had a feeling it was but couldn't find another instance of it being used. Will work on those changes. Tests might take a bit longer as I havnt done them before but I'm sure il figure it out.

…

On April 14, 2020 8:10:51 AM Jack Meyer ***@***.***> wrote: @jackcmeyer requested changes on this pull request. Hi @jlato89! Few changes requested: address comment add test to show that DatePickerWithLabelFormGroup passes maxDate value to DateTimePicker from @hospitalrun/components add test to show that GenrealInformation component sets the max date value to the current day In src/components/input/DatePickerWithLabelFormGroup.tsx: > @@ -22,6 +23,7 @@ const DatePickerWithLabelFormGroup = (props: Props) => { > dateFormat="MM/dd/yyyy" dateFormatCalendar="LLLL yyyy" dropdownMode="scroll" + maxDate={addDays(new Date(), 0)} This component is intended to be more general than for use inside of the new/edit patient screen. I think that this interface will only need to expose an optional maxDate and just pass it along to the DateTimePicker from @hopsitalrun/components`. Then we'll need to make a change in the GenrealInformationComponent to set the maxDate property. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[jlato89]

Added the appropriate changes. Just have to figure out how todo the tests. Then it will be ready to be merged.

[vercel]

Deployment failed with the following error:

request to https://api.zeit.co/v12/now/deployments?teamId=team_KiGwX2JSRgAI3krc36DK1uGg&skipAutoDetectionConfirmation=1 failed, reason: socket hang up

[jackcmeyer]

closing in favor of #2002