Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(patients): add related persons form feedback #1957

Closed
wants to merge 1 commit into from

Conversation

bmoore235
Copy link
Contributor

Fixes #1925.

Changes proposed in this pull request:

  • Updated Error Feedback on NewRelatedPersonModal
  • Added New Error Messages to the Translation Index
  • Updated Tests

Newly added dependencies with Bundlephobia links:

  • None

_Note: I updated the tests so 'should display an error message if given name or relationship type is not entered.' will pass, but I am having difficulty with writing tests specifically for the new error feedback.

@vercel
Copy link

vercel bot commented Apr 1, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/niuwgg33s
✅ Preview: https://hospitalrun-frontend-git-fork-bmoore235-master.hospitalrun.now.sh

@jackcmeyer jackcmeyer requested review from fox1t and jackcmeyer April 1, 2020 19:58
@jackcmeyer jackcmeyer added 🚀enhancement an issue/pull request that adds a feature to the application patients issue/pull request that interacts with patients module labels Apr 1, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Apr 1, 2020
@fox1t
Copy link
Member

fox1t commented Apr 2, 2020

Can you please resolve the conflicts?

Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be merged after conflicts resolution.

Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @bmoore235.

I've requested some small code tweaks and for some tests to get added! Let me know if you need any help

@jackcmeyer jackcmeyer changed the title feat(newrelatedpersonmodal): update Error Feedback feat(patients): add related persons form feedback Apr 3, 2020
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Apr 8, 2020
@jackcmeyer
Copy link
Member

Hey @bmoore235, let me know if you need any help getting this pull request finished up!

@jackcmeyer
Copy link
Member

closing in favor of #1991

@fox1t fox1t closed this Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Related Persons modal should provide better error feedback
4 participants