Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(patients): add required field label for diagnosis #1936

Merged
merged 1 commit into from
Mar 21, 2020
Merged

fix(patients): add required field label for diagnosis #1936

merged 1 commit into from
Mar 21, 2020

Conversation

nwmandel
Copy link
Contributor

@nwmandel nwmandel commented Mar 21, 2020 •
edited by jackcmeyer
Loading

Added required fields to diagnosis name and date

Fixes #1926

Changes proposed in this pull request:

  • Added optional isRequired field to DatePickerWithLabelFormGroup
  • Added isRequired to both fields in the AddDiagnosisModal

@jsf-clabot
Copy link

jsf-clabot commented Mar 21, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Mar 21, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/gsly1pge9
✅ Preview: https://hospitalrun-frontend-git-fork-nwmandel-master.hospitalrun.now.sh

@jackcmeyer jackcmeyer self-requested a review March 21, 2020 20:26
@jackcmeyer jackcmeyer added 🐛bug issue/pull request that documents/fixes a bug patients issue/pull request that interacts with patients module labels Mar 21, 2020
@jackcmeyer jackcmeyer changed the title fix(adddiagnosismodal and datepickerwithlabelformgroups): required field fix(patients): required field Mar 21, 2020
@jackcmeyer jackcmeyer changed the title fix(patients): required field fix(patients): add required field label for diagnosis Mar 21, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Mar 21, 2020
@jackcmeyer jackcmeyer added 🚀enhancement an issue/pull request that adds a feature to the application and removed 🐛bug issue/pull request that documents/fixes a bug labels Mar 21, 2020
@jackcmeyer
Copy link
Member

LGTM, thanks for the contribution @nwmandel.

@jackcmeyer jackcmeyer merged commit da98fc3 into HospitalRun:master Mar 21, 2020
@nwmandel
Copy link
Contributor Author

@jackcmeyer happy to help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackcmeyer jackcmeyer jackcmeyer approved these changes

Assignees
No one assigned
Labels
🚀enhancement an issue/pull request that adds a feature to the application patients issue/pull request that interacts with patients module
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Add Diagnosis Modal should mark required fields
3 participants
@nwmandel @jsf-clabot @jackcmeyer