This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Feature/add notes to patients #1896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged from HospitalRun/hospitalrun-frontend
Merge from HospitalRun/hospitalrun-frontend
Merged from HospitalRun/hospitalrun-frontend
Merge from Origin
|
|
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/1mddvva9w |
jackcmeyer
suggested changes
Mar 13, 2020
| onSave: (note: Note) => void | ||
| } | ||
|
|
||
| const NewNoteModal = (props: Props) => { |
There was a problem hiding this comment.
Need to add tests for this modal.
| patient: Patient | ||
| } | ||
|
|
||
| const NoteTab = (props: Props) => { |
There was a problem hiding this comment.
Need to add tests for the notes tab:
- renders an add new button for someone with permissions
- doesn't render the button if no permissions
- renders a warning message if no notes
- renders a list of notes
- Clicking button displays modal
- Saving calls the update patient action
- On successful save, a toast appears
matteovivona
added
the
in progress
matteovivona
suggested changes
Mar 14, 2020
There was a problem hiding this comment.
Hi @wwbarros. Thanks for your PR. Please, add more tests :)
Closed
matteovivona
approved these changes
Mar 31, 2020
|
closing in favor of #1961 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1771 .
Changes proposed in this pull request: