App nav redesign phase 1 #108
Conversation
| 'The international telephone dialing code for Antarctica is 672.', | ||
| 'Camels chew in a figure 8 pattern.', | ||
| 'A shark is the only fish that can blink with both eyes.' | ||
| ] |
There was a problem hiding this comment.
@jkleinsc I 🔥 these because the felt distracting, and are generally visible too short of a time to be useful/interesting.
There was a problem hiding this comment.
Actually in the Philippines with a large data set, some screens need something like this because some screens take a while to load. We should be able to address the performance issues and I guess I am fine with removing these.
There was a problem hiding this comment.
Actually in the Philippines with a large data set, some screens need something like this because some screens take a while to load.
Okay, well if that's the case, I understand why they were there, but still think having something generic (like the loading animation) is more appropriate.
@jkleinsc I’m running into an issue where the category I put into the sidebar isn’t rendering there. Is that expected? What do I need to modify to make it render in the new location (navigation.hbs)?
Summary of visual changes so far:App loading noticeRedesigned the loading notice to be a bit more subtle, and less distracting: Started setting up the sidebar navRepositioned the sign in dialogCurrently blocked on getting the primary category nav items into the sidebar from the index. They don't render there as is. More on that in this commit. |
|
Since i haven't posted a screencap lately, here's few of the latest. The layout is getting pretty close, just need to spend some time addressing the form styles, and the sidebar collapsed styling. Loading
Login
Dashboard
View category
|
cc @jkleinsc btw these else statements look like a great candidate for DRYing up. The markup is nearly identical, except for the phrasing.
|
I merged in master and resolved conflicts, but I'd like to get this branch merged in 🔜 so it doesn't get to big/divergent from master. @tangollama any update on the nav functionality? |
|
@jkleinsc @tangollama so any idea why the nav still doesn't show up when you initially login, and how we can resolve that? I have to refresh the page to get it to appear once logged in. Would you prefer we get that fixed in this branch, or get this merged into master and fix in a new branch? |
One element opens at a time. Note that I don’t think this is going to function properly for direct links. Unsure.
|
Okay, merging this in for benefit of scope and so this pull doesn't get too big. |
This pull redesigns the application navigational paradigm as described in #103, moving from a separate screen based nav, to a constantly visible/accessible sidebar nav.
Will post screenshots here as development progresses.
TODO