Translations of delete messages across the application

[billybonks]

There are currently a few delete messages in the translations file, namely:

delete_patient:'Are you sure you wish to delete {{firstName}} {{lastName}}?',
are_you_sure_delete: 'Are you sure you wish to delete the user {{user}}?',
delete_item:'Are you sure you wish to delete {{item}}?',
are_you_sure_delete: 'Are you sure you want to delete this {{object}}?',
confirm_deletion: 'Are you sure you wish to delete this lab request?',
delete: 'Are you sure you wish to delete this visit?'
delete: 'Are you sure you wish to delete these vitals?'
delete: 'Are you sure you wish to delete {{name}}?',
delete_medication: 'Are you sure you want to delete this medication?',
delete: 'Are you sure you wish to delete this procedure?'
delete: 'Are you sure you wish to delete this imaging request?',

below i have grouped the strings that are similar

1.'Are you sure you wish to delete {{item}}?' - billing item
2.'Are you sure you wish to delete {{name}}?', - inventory item

3.'Are you sure you want to delete this {{object}}?', -patient
4.'Are you sure you wish to delete this lab request?',
5.'Are you sure you wish to delete this visit?'
6.'Are you sure you want to delete this medication?',
7.'Are you sure you wish to delete this procedure?'

8.'Are you sure you wish to delete these vitals?'

we can change this to be only 3 strings, and use them across the application

en: {
  messages: {
    delete: 'Are you sure you wish to delete {{name}}?'
    delete_singular: 'Are you sure you wish to delete this{{name}}?'
    delete_plural: 'Are you sure you wish to delete {{name}}?'
  }
}

[jkleinsc]

@billybonks I am in favor of doing this. I think it presents consistency across the app.

[chantmich]

I can update the french translations

[rafajaques]

Need help with portuguese?

[yasirunilan]

Can I work on this?

[tangollama]

Go for it.

On Saturday, October 15, 2016, yasirunilan [email protected] wrote:

Can I work on this?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#543 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4t7V3Vys7mFfBT-HSl5jw28bgfxaLXks5q0PUWgaJpZM4JDITK
.

*Joel Worrall *
@tangollama http://twitter.com/tangollama (c) 717.385.9970

[mdarmanin]

@tangollama I will also start working on this now and submit a PR.

[mdarmanin]

@billybonks 3. and 6. are not similar to the rest in the group, namely "want" and "wish". Change all to wish?

[jkleinsc]

@mdarmani @yasirunilan asked to work on it first and @tangollama agreed. I am going to move it to in progress with @yasirunilan working on it.

The main issue here is to actually move from the multiple messages to just these 3:

en: {
  messages: {
    delete: 'Are you sure you wish to delete {{name}}?'
    delete_singular: 'Are you sure you wish to delete this{{name}}?'
    delete_plural: 'Are you sure you wish to delete {{name}}?'
  }
}

This will require changing the translation files as well as changing everywhere these messages are called.

[billybonks]

@jkleinsc is correct

[yasirunilan]

yeah I'm working on this