Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Fix styling for login alert #273

Closed
jglovier opened this issue Jan 22, 2016 · 3 comments
Closed

Fix styling for login alert #273

jglovier opened this issue Jan 22, 2016 · 3 comments
Assignees

Comments

@jglovier
Copy link
Member

This styling (added in #250) doesn't match the app's design. Also, the alert should be above the button, or maybe above the input fields.

image

@alexpelan
Copy link
Contributor

I can fix (it looks like you may have already started, though?) I did cause
it, after all...

On Fri, Jan 22, 2016 at 11:23 AM, Joel Glovier [email protected]
wrote:

This styling (added in #250
#250) doesn't
match the app's design. Also, the alert should be above the button, or
maybe above the input fields.

[image: image]
https://cloud.githubusercontent.com/assets/1319791/12516210/4aa7fab6-c0fa-11e5-845d-48a946d2a677.png


Reply to this email directly or view it on GitHub
#273.

@jglovier
Copy link
Member Author

@alexpelan thanks, but I've got a branch in progress with some other login tweaks as well. 🙇

@jglovier
Copy link
Member Author

@alexpelan FWIW, it's really not your fault. We really have a long way to go on the styling of the app, and I'd like to get to a place that we have all the components available and styled correctly so that contributing devs can just jump in and use the existing styles. Right now, we have a lot of default bootstrap styles that should really be themed. So properly theming bootstrap and removing unused styles is one of the things I'm focusing on now. ❤️

jglovier pushed a commit that referenced this issue Jan 22, 2016
@tangollama tangollama added the in progress indicates that issue/pull request is currently being worked on label Jan 23, 2016
@tangollama tangollama removed the in progress indicates that issue/pull request is currently being worked on label Jan 23, 2016
matteovivona pushed a commit that referenced this issue Jan 15, 2021
Refactor to remove querySelector calls where possible
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants