Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Standardize react router imports in tests and source code #2061

Closed
jackcmeyer opened this issue May 11, 2020 · 1 comment · Fixed by #2067
Closed

Standardize react router imports in tests and source code #2061

jackcmeyer opened this issue May 11, 2020 · 1 comment · Fixed by #2067
Labels
good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button)
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

🐛 Bug Report

In some cases, the react router imports are different.

All react router imports should come from react-router-dom instead of react-router per the documentation here: https://reacttraining.com/react-router/web/guides/quick-start
@jackcmeyer jackcmeyer added help wanted indicates that an issue is open for contributions good first issue indicates an issue is good for a first time contributor LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button) labels May 11, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone May 11, 2020
@sourabbanka22
Copy link
Contributor

Hi @jackcmeyer , is it possible to attempt this one?

sourabbanka22 added a commit to sourabbanka22/hospitalrun-frontend that referenced this issue May 12, 2020
@sourabbanka22
fix: standardized react router imports in tests and source code
f91d38b 
Standardizing react router imports in tests and source code such that all react router imports
should come from react-router-dom instead of react-router.

fix HospitalRun#2061
@sourabbanka22 sourabbanka22 mentioned this issue May 12, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button)
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

fix: standardized react router imports in tests and source code sourabbanka22/hospitalrun-frontend
2 participants
@jackcmeyer @sourabbanka22