Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Labs should sort by requested date by default #1966

Closed
jackcmeyer opened this issue Apr 5, 2020 · 5 comments · Fixed by #2004
Closed

Labs should sort by requested date by default #1966

jackcmeyer opened this issue Apr 5, 2020 · 5 comments · Fixed by #2004
Assignees
@akshay-ap
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on labs issue/pull request that interacts with labs module
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

jackcmeyer commented Apr 5, 2020 •
edited
Loading

🚀 Feature Proposal

Labs should sort by requested date by default (the newest one should come first) when I am viewing the list of labs

Motivation

Easier to find lab requests

Blocked by

#1969
@jackcmeyer jackcmeyer self-assigned this Apr 5, 2020
@jackcmeyer jackcmeyer transferred this issue from HospitalRun/hospitalrun Apr 5, 2020
@jackcmeyer jackcmeyer added core-team indicates that the issue will be completed by a core team member 🚀enhancement an issue/pull request that adds a feature to the application labs issue/pull request that interacts with labs module labels Apr 5, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Apr 5, 2020
@jackcmeyer jackcmeyer added 🚧blocked issue cannot be worked on for some reason and removed core-team indicates that the issue will be completed by a core team member labels Apr 5, 2020
@jackcmeyer jackcmeyer removed their assignment Apr 5, 2020
@jackcmeyer jackcmeyer added help wanted indicates that an issue is open for contributions and removed 🚧blocked issue cannot be worked on for some reason labels Apr 18, 2020
@akshay-ap
Copy link
Contributor

I would like to work on this.

@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Apr 19, 2020
@jackcmeyer
Copy link
Member Author

@akshay-ap sounds great! I've assigned this to you.

@akshay-ap
Copy link
Contributor

@jackcmeyer Before starting to work on it, I have a suggestion: A new dropdown which will show the fields by which the list of Labs can be sorted in ascending or descending order:

  1. ResquestedOn
  2. Type
  3. Status
    By default, list will be sorted by ResquestedOn descending order.

image

@jackcmeyer
Copy link
Member Author

@akshay-ap

I like this idea. However, most of the sorting functionality is going to be fully implemented inside of the Table component.

For now, the intent of this was to get basic functionality implemented so that it is a usable feature.

If the solution that you are suggesting is simple enough, then I'd say go for it. However, it is likely that the UI part of the story will change in the future.

akshay-ap added a commit to akshay-ap/hospitalrun-frontend that referenced this issue Apr 21, 2020
@akshay-ap
feat(viewlabs): sort Labs by requestedOn field
d22a174 
feat HospitalRun#1966
@akshay-ap akshay-ap mentioned this issue Apr 21, 2020
Merged
akshay-ap added a commit to akshay-ap/hospitalrun-frontend that referenced this issue Apr 21, 2020
@akshay-ap
feat(viewlabs): sort Labs by requestedOn field
d026ae7 
fix HospitalRun#1966
ghost pushed a commit to akshay-ap/hospitalrun-frontend that referenced this issue Apr 21, 2020
Merge branch 'master' into fix-HospitalRun#1966
da2b436
ghost pushed a commit to akshay-ap/hospitalrun-frontend that referenced this issue Apr 21, 2020
Merge branch 'master' into fix-HospitalRun#1966
30449b0
ghost pushed a commit to akshay-ap/hospitalrun-frontend that referenced this issue Apr 22, 2020
Merge branch 'master' into fix-HospitalRun#1966
0d0b87d
ghost pushed a commit to akshay-ap/hospitalrun-frontend that referenced this issue Apr 22, 2020
Merge branch 'master' into fix-HospitalRun#1966
c21e8cb
ghost pushed a commit to akshay-ap/hospitalrun-frontend that referenced this issue Apr 22, 2020
Merge branch 'master' into fix-HospitalRun#1966
b5b4587
ghost pushed a commit to akshay-ap/hospitalrun-frontend that referenced this issue Apr 22, 2020
Merge branch 'master' into fix-HospitalRun#1966
413a39c
ghost pushed a commit to akshay-ap/hospitalrun-frontend that referenced this issue Apr 22, 2020
Merge branch 'master' into fix-HospitalRun#1966
e24ca14
ghost pushed a commit to akshay-ap/hospitalrun-frontend that referenced this issue Apr 22, 2020
Merge branch 'master' into fix-HospitalRun#1966
fdec4d6
akshay-ap added a commit to akshay-ap/hospitalrun-frontend that referenced this issue Apr 22, 2020
@akshay-ap
test(viewlabs): add test - findAll called with sort request
d55dbb7 
fix HospitalRun#1966
akshay-ap added a commit to akshay-ap/hospitalrun-frontend that referenced this issue Apr 22, 2020
@akshay-ap
Merge branch 'master' of https://github.com/HospitalRun/hospitalrun-f…
29cd413 
…rontend into fix-HospitalRun#1966
akshay-ap added a commit to akshay-ap/hospitalrun-frontend that referenced this issue Apr 22, 2020
@akshay-ap
Merge branch 'fix-HospitalRun#1966' of https://github.com/akshay-ap/h…
9057fe5 
…ospitalrun-frontend into fix-HospitalRun#1966
ghost pushed a commit to akshay-ap/hospitalrun-frontend that referenced this issue Apr 22, 2020
Merge branch 'master' into fix-HospitalRun#1966
5b24702
@jackcmeyer jackcmeyer linked a pull request Apr 23, 2020 that will close this issue
feat(viewlabs): sort Labs by requestedOn field #2004
Merged
@jackcmeyer
Copy link
Member Author

Closed via #2004

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@akshay-ap akshay-ap

Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on labs issue/pull request that interacts with labs module
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

feat(viewlabs): sort Labs by requestedOn field akshay-ap/hospitalrun-frontend
2 participants
@akshay-ap @jackcmeyer