Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

New Related Persons Modal should mark required fields #1927

Closed
jackcmeyer opened this issue Mar 19, 2020 · 1 comment · Fixed by #1950
Closed

New Related Persons Modal should mark required fields #1927

jackcmeyer opened this issue Mar 19, 2020 · 1 comment · Fixed by #1950
Assignees
@bmoore235
Labels
🚀enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

🚀 Feature Proposal

The related person field and relationship type field should be marked with a * to indicate that it is required.

Motivation

Better use experience.
@jackcmeyer jackcmeyer transferred this issue from HospitalRun/hospitalrun Mar 19, 2020
@jackcmeyer jackcmeyer added 🚀enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions patients issue/pull request that interacts with patients module labels Mar 19, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Mar 19, 2020
@bmoore235
Copy link
Contributor

I would love to tackle this issue, along with Related Persons modal should provide better error feedback #1925

@bmoore235 bmoore235 mentioned this issue Mar 19, 2020
Closed
@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Mar 19, 2020
jamesinsf-git added a commit to jamesinsf-git/hospitalrun-frontend that referenced this issue Mar 29, 2020
@jamesinsf-git
fix: indicate required fields in new Related Person Modal
6b8481b 
fix HospitalRun#1927
@jamesinsf-git jamesinsf-git mentioned this issue Mar 29, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bmoore235 bmoore235

Labels
🚀enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

feat: indicate required fields in new Related Person Modal jamesinsf-git/hospitalrun-frontend
2 participants
@jackcmeyer @bmoore235