Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Make left hand sidebar items collapsible and allow for sub-links #1857

Closed
jackcmeyer opened this issue Feb 25, 2020 · 9 comments · Fixed by #1956
Closed

Make left hand sidebar items collapsible and allow for sub-links #1857

jackcmeyer opened this issue Feb 25, 2020 · 9 comments · Fixed by #1956
Assignees
Labels
🚀enhancement an issue/pull request that adds a feature to the application help wanted indicates that an issue is open for contributions in progress indicates that issue/pull request is currently being worked on ux
Milestone

Comments

@jackcmeyer
Copy link
Member

jackcmeyer commented Feb 25, 2020

🚀 Feature Proposal

The left hand sidebar should make the items collapsible and allow for sub links.

Sidebar should look something like:

- Dashboard
- Patient
  - New Patient
  - Patient List  
- Scheduling
   - New Appointment
   - Appointment Schedule

When accessing any route /patient/**, the Patients item should be highlighted.
When accessing any route /appointments/** the Scheduling item should be highlighted.

Sub items should also be properly marked active. (E.g. when New Patient screen is shown, Patient Item should be highlighted and New Patient item should be highlighted.

Clicking on any other section should collapse the previously selected section and expand the newly selected one.

Example

It should operate very similarly to http://demo.hospitalrun.io/

Technical Notes

Should remove dropdown links from Navbar.

@jackcmeyer jackcmeyer transferred this issue from HospitalRun/hospitalrun Feb 25, 2020
@jackcmeyer jackcmeyer added 🚀enhancement an issue/pull request that adds a feature to the application help wanted indicates that an issue is open for contributions labels Feb 25, 2020
@jackcmeyer jackcmeyer added this to the v2.0.0 milestone Feb 25, 2020
@anis-agwan
Copy link

Is this issue available to solve?

@sotous
Copy link
Contributor

sotous commented Mar 18, 2020

Hi! @jackcmeyer , may I have this issue assigned?

@jackcmeyer
Copy link
Member Author

@sotous I have assigned this to you!

@jackcmeyer jackcmeyer added the in progress indicates that issue/pull request is currently being worked on label Mar 18, 2020
@sotous
Copy link
Contributor

sotous commented Mar 19, 2020

Thanks!

@sotous
Copy link
Contributor

sotous commented Mar 20, 2020

So I simulated the layout, nothing to fancy, just an idea and my approach to the issue, I would love your feedback @jackcmeyer in order to start working on the proposal.

Just consider the sidebar, as I said it is just an approach, so the dropdown links haven't been removed yet.

image

@jackcmeyer
Copy link
Member Author

This looks like the right approach!

Some general feedback:

  • I'm not sure the children of the selected option need to be highlighted in a lighter shade of green. I would expect only the parent and the currently selected child to be highlighted.
  • We may need some sort of indication that the parents are able to be expanded and collapsed.

@sotous
Copy link
Contributor

sotous commented Mar 22, 2020

Ok I got it.

However, how should I highlight the non-selected child?, also, do you have any color suggestions to make a difference between parent and child?

@jackcmeyer
Copy link
Member Author

@sotous just the default white for any selected children. I'm not sure that a color separation between the selected parent and the selected child is necessary.

@fox1t
Copy link
Member

fox1t commented Mar 23, 2020

Here we have to hear something from @StefanoMiC too!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application help wanted indicates that an issue is open for contributions in progress indicates that issue/pull request is currently being worked on ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants