fix(frontend): update navbar component to match new format

[ocBruno]

BREAKING CHANGE: update components package changing some interfaces

fix #1781

Changes proposed in this pull request:

• update components package
• update navbar to match changes

https://github.com/HospitalRun/components
32.2

[vercel]

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/66b9aisfo
✅ Preview: https://hospitalrun-frontend-git-fork-ocbruno-fix-update-navbar.hospitalrun.now.sh

[ocBruno]

Hey @jackcmeyer
To be able to finish resolving this efficiently, I need to first create a pull request to update the components library to add className identifiers to the navitems to be able to properly test.
I will create a pull request for that before finishing up this update.

[jackcmeyer]

Hey @jackcmeyer
To be able to finish resolving this efficiently, I need to first create a pull request to update the components library to add className identifiers to the navitems to be able to properly test.
I will create a pull request for that before finishing up this update.

@ocBruno doesn't NavItems already have a className https://github.com/HospitalRun/components/blob/9a492170d88d103b7d00454392cd77923ce2f2d3/src/components/Navbar/interfaces.tsx#L4?

[jackcmeyer]

Code loks good, just need some tests to get update

[ocBruno]

Hey @jackcmeyer
To be able to finish resolving this efficiently, I need to first create a pull request to update the components library to add className identifiers to the navitems to be able to properly test.
I will create a pull request for that before finishing up this update.

@ocBruno doesn't NavItems already have a className https://github.com/HospitalRun/components/blob/9a492170d88d103b7d00454392cd77923ce2f2d3/src/components/Navbar/interfaces.tsx#L4?

Ahh yes, I was going to add a default identifiers such as nav-header and nav-icon but now that you mentioned the built in one i'm not sure we need to, I will add classes to each item and test them with those.
** Edit **
I realized there could be some refactoring in the components library to improve test structure in the projects. There is some unnecessary nesting such as in the navheader.

[ocBruno]

Hey @jackcmeyer
To be able to finish resolving this efficiently, I need to first create a pull request to update the components library to add className identifiers to the navitems to be able to properly test.
I will create a pull request for that before finishing up this update.

@ocBruno doesn't NavItems already have a className https://github.com/HospitalRun/components/blob/9a492170d88d103b7d00454392cd77923ce2f2d3/src/components/Navbar/interfaces.tsx#L4?

Hey @jackcmeyer,

finished updating the tests and suggested a new structure with some improvements we could apply to other tests!