Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Property 'brand' does not exist on type IntrinsicAttributes #1781

Closed
matteovivona opened this issue Feb 2, 2020 · 0 comments · Fixed by #1782
Closed

Property 'brand' does not exist on type IntrinsicAttributes #1781

matteovivona opened this issue Feb 2, 2020 · 0 comments · Fixed by #1782
Labels
🐛bug issue/pull request that documents/fixes a bug dependencies Pull requests that update a dependency file good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on
Milestone

Comments

@matteovivona
Copy link
Contributor

matteovivona commented Feb 2, 2020

💥 Regression Report

Seems to be an incompatibility with new version 0.32.0 of components

Last working version

Worked up to version: 0.31.0

Stopped working in version: 0.32.0

TypeScript error in /home/travis/build/HospitalRun/hospitalrun-frontend/src/components/Navbar.tsx(12,7):

Type '{ brand: { label: string; onClick: () => void; }; search: { onClickButton: () => void; onChangeInput: () => void; placeholderText: string; buttonText: string; }; navLinks: { label: string; onClick: () => void; children: { ...; }[]; }[]; }' is not assignable to type 'IntrinsicAttributes & Pick<Props, "ref" | "className" | "children" | "navItems" | "key"> & Partial<Pick<Props, "bg" | "variant">> & Partial<...>'.

Property 'brand' does not exist on type 'IntrinsicAttributes & Pick<Props, "ref" | "className" | "children" | "navItems" | "key"> & Partial<Pick<Props, "bg" | "variant">> & Partial<...>'.  TS2322    
10 |   return (   
11 |     <HospitalRunNavbar  > 
12 |       brand={{       |       ^    
13 |         label: 'HospitalRun',    
14 |         onClick: () => {    
15 |           history.push('/')
@matteovivona matteovivona added 🐛bug issue/pull request that documents/fixes a bug help wanted indicates that an issue is open for contributions good first issue indicates an issue is good for a first time contributor dependencies Pull requests that update a dependency file labels Feb 2, 2020
ocBruno added a commit to ocBruno/hospitalrun-frontend that referenced this issue Feb 2, 2020
BREAKING CHANGE: update components package changing some interfaces

fix HospitalRun#1781
ocBruno added a commit to ocBruno/hospitalrun-frontend that referenced this issue Feb 2, 2020
@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Feb 2, 2020
@jackcmeyer jackcmeyer added this to the v2.0.0 milestone Feb 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛bug issue/pull request that documents/fixes a bug dependencies Pull requests that update a dependency file good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants