Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Add internationalization support #141

Closed
jkleinsc opened this issue Jul 16, 2015 · 13 comments
Closed

Add internationalization support #141

jkleinsc opened this issue Jul 16, 2015 · 13 comments
Assignees
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on localization

Comments

@jkleinsc
Copy link
Member

In order to support different languages in HospitalRun we need to implement ember-i18n throughout the app

@jkleinsc jkleinsc added the 🚀enhancement an issue/pull request that adds a feature to the application label Jul 16, 2015
This was referenced Jul 16, 2015
@billybonks
Copy link
Contributor

Hi, i have been looking for some way to contribute to the project, and i think this is a good issue to work on, since it's a nice way to explore the code base 😄.

i notice we are quite far back in terms of ember version, so we would have to use 3.x I18n. would it be a huge task to upgrade the version of ember that we are using ?

@jkleinsc
Copy link
Member Author

@billybonks One of the things on my todo list is to upgrade to Ember 1.13, then fix the deprecation warnings in preparation for Ember 2.x

Do you know how much of a difference there is between 3.x i18n and 4.x? If they are significantly different, I would prefer to wait until we can pull in 4.x.

@tangollama tangollama added the help wanted indicates that an issue is open for contributions label Aug 4, 2015
@tangollama tangollama modified the milestone: HospitalRun 1.0 Oct 12, 2015
@tangollama
Copy link
Member

@billybonks, given that this conversation went cold back in July b/c of the upgrade work, I'm guessing you didn't start anything with this; but I wanted to ask if this was on your radar or if I should be looking for someone else to look into it? No worries either way. Just asking.

@billybonks
Copy link
Contributor

@tangollama, let me try set this up this weekend otherwise, ill drop it 👍 my time has been limited lately

@tangollama
Copy link
Member

Word.

@jonkoops
Copy link

@billybonks Any update on this?, would love to help out.

@jkleinsc
Copy link
Member Author

@jonkoops @billybonks had a PR that setup localization and that has been merged and at this point what is needed is to convert all of the templates to use localized text. I was intending on creating issues for each functional area to convert the templates but I haven't done so yet.

@jonkoops
Copy link

@jkleinsc Alright, let me know when you do then I'll pick some up.

@jkleinsc
Copy link
Member Author

@jonkoops The following localization issues have been added:
#274, #275, #276, #277, #278, #279, #280, 281

@mDantas
Copy link

mDantas commented Jan 22, 2016

@jkleinsc @jonkoops just wanted to say hi and that'd I'd be interested in helping out too.

@jonkoops
Copy link

@mDantas I'll take the Patients module, maybe you can work on the Appointments module at the same time?

@jkleinsc
Copy link
Member Author

jkleinsc commented Mar 7, 2016

Once all the localization has been completed, we should add [ember-cli-template-lint] https://github.com/rwjblue/ember-cli-template-lint to verify that all of our templates are using translated strings.

@tangollama tangollama added the in progress indicates that issue/pull request is currently being worked on label Mar 15, 2016
@tangollama tangollama removed the help wanted indicates that an issue is open for contributions label Mar 15, 2016
@jkleinsc
Copy link
Member Author

jkleinsc commented Oct 6, 2016

All issues complete. Closing this issue.

@jkleinsc jkleinsc closed this as completed Oct 6, 2016
matteovivona pushed a commit that referenced this issue Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on localization
Projects
None yet
Development

No branches or pull requests

5 participants