Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

New schemas #23

Merged
merged 8 commits into from
May 27, 2020
Merged

New schemas #23

merged 8 commits into from
May 27, 2020

Conversation

jackcmeyer
Copy link
Member

Changes proposed in this pull request:

  • appointment schema
  • incident schema
  • fix eslint config

@jackcmeyer jackcmeyer requested a review from fox1t May 5, 2020 02:08
@gitpod-io
Copy link

gitpod-io bot commented May 5, 2020

@fox1t
Copy link
Member

fox1t commented May 14, 2020

Our build is broken because of 3.9.2 TS "fixes" to generics.

@fox1t
Copy link
Member

fox1t commented May 14, 2020

We will wait for the fix on the dependency/typescript side.
microsoft/TypeScript#38460

Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matteovivona matteovivona changed the base branch from feature/model-schema-types to master May 15, 2020 07:36
@fox1t
Copy link
Member

fox1t commented May 15, 2020

@jackcmeyer can you please fix typescript version to 3.8.3 to avoid regression on intersections and unions? After that, this is going to be merged! :)

Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix TS to 3.8.3

@matteovivona matteovivona self-requested a review May 27, 2020 07:42
@matteovivona matteovivona merged commit de7b34a into master May 27, 2020
@matteovivona matteovivona deleted the new-schemas branch May 27, 2020 19:12
@ghost
Copy link

ghost commented Jul 2, 2020

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ghost ghost added the released label Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants