feat(navbar): adds customizable search and label color #148
Conversation
add customizable search placeholder/button text and label color feat
Fixed the doc according to brand property but think we should extract each Class property into individual files into a Navbar folder for easier navigation, visualization and an improved structure fix #131
| </NavbarRB.Brand> | ||
|
|
||
| <NavbarRB.Collapse id="responsive-navbar-nav"> | ||
| <Nav className="mr-auto">{navLinks.map((link, index) => getNavLinks(link, index))}</Nav> | ||
| <Nav> | ||
| <Form inline> | ||
| <FormControl |
There was a problem hiding this comment.
We might want to consider refactoring this text box to be our own TextBox component. Do you want to do that in this pull request. Otherwise, we can open an issue and do it later
There was a problem hiding this comment.
I was giving this one a shot but I am a little lost on the necessary props and how what will be used as TextBox so I'm not sure if i commit my best attempt with atleast the basic structure in place or if we leave it for another issue. Thanks for the feedback!
matteovivona
changed the title
|
@ocBruno There are some label related files in here. Could you remove them, please? |
Of course! Still getting used to everything 🤕 😄 |
Fix tests caused by outdated component by merging branches fix #148
|
LGTM |
# [0.23.0](v0.22.2...v0.23.0) (2019-12-30) ### Bug Fixes * **navbar:** fix-missing-required-test-search-properties ([be406a0](be406a0)), closes [#148](#148) * **navbar:** fix-navbar-mistakes ([a962b51](a962b51)), closes [#148](#148) * **navbar:** fix-navbar-mistakes ([e7abf72](e7abf72)), closes [#148](#148) * **navbar:** fix-tests ([5e3bb16](5e3bb16)), closes [#148](#148) * **navbar:** fix-tests-attempt ([0628329](0628329)), closes [#148](#148) * **navbar:** make-onchange-required ([de0ebdd](de0ebdd)), closes [#148](#148) * **navbar:** remove unrelated commits ([7d6a473](7d6a473)), closes [#148](#148) ### Features * **calendar:** add ability to choose available views ([0875a5b](0875a5b)) * **calendar:** add calendar component ([820a3a0](820a3a0)) * **checkbox:** add className and style props ([689805e](689805e)) * **navbar:** add customizable search placeholder/button text ([106c530](106c530)) * **navbar:** add test for default props ([8c238c1](8c238c1)), closes [#148](#148)
|
🎉 This PR is included in version 0.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
add customizable search placeholder/button text and label color
feat
Fixes #131
Changes proposed in this pull request:
(Separate brand and search properties which are class instances into individual doc files of Navbar folder for better structure, organization and navigation.
-I had to close and create a new pull request because I had the wrong email configured in my git