Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(datetimepicker): add support for multiple languages #438

Merged
merged 10 commits into from
Jun 5, 2020
Merged

feat(datetimepicker): add support for multiple languages #438

merged 10 commits into from
Jun 5, 2020

Conversation

vicdurai
Copy link
Contributor

Fixes #324 .

Changes proposed in this pull request:

  • Added support for multiple languages (supported by the UI at the time of writing) for DateTimePicker.
  • Added story to demonstrate new languages.
  • Also added support for onClick indropdown.)

Newly added dependencies with Bundlephobia links:
N/A

feat(datetimepicker.tsx and dropdown.tsx): multiple languages, onClick
ab390db 
Added support for multiple languages (supported by the UI at the time of writing) for
DateTimePicker. Added story to demonstrate new languages. Also added support for onClick in
dropdown.)

fix HospitalRun#324
@jsf-clabot
Copy link

jsf-clabot commented May 25, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vicdurai vicdurai mentioned this pull request May 25, 2020
Closed
@matteovivona matteovivona added this to the v1.0.0 milestone May 26, 2020
@matteovivona matteovivona changed the title feat(datetimepicker.tsx and dropdown.tsx): multiple languages, onClick feat(datetimepicker): add support for multiple languages May 26, 2020
matteovivona
matteovivona previously approved these changes May 26, 2020
View reviewed changes
jackcmeyer
jackcmeyer suggested changes May 27, 2020
View reviewed changes
src/components/DateTimePicker/DateTimePicker.tsx Outdated Show resolved Hide resolved
src/components/Dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
@matteovivona matteovivona removed this from the v1.0.0 milestone Jun 2, 2020
@matteovivona
Copy link
Contributor

@vicdurai could you resolve the conflict? Thank you!

@vicdurai
Copy link
Contributor Author

vicdurai commented Jun 4, 2020

@vicdurai could you resolve the conflict? Thank you!

Sorry for the delay. Will finish this today

feat(datetimepicker, dropdown): support all languages
8e42796 
Supports all languages provided by date-fns/locale. Also fixes comments left on PR.

re HospitalRun#438
@vicdurai vicdurai requested a review from jackcmeyer June 4, 2020 19:34
@matteovivona matteovivona merged commit a667e10 into HospitalRun:master Jun 5, 2020
ghost pushed a commit that referenced this pull request Jun 5, 2020
@semantic-release-bot
chore(release): 1.12.0 [skip ci]
1d44af2 
# [1.12.0](v1.11.0...v1.12.0) (2020-06-05)

### Features

* **datetimepicker, dropdown:** support all languages ([8e42796](8e42796)), closes [#438](#438)
* **datetimepicker.tsx and dropdown.tsx:** multiple languages, onClick ([ab390db](ab390db)), closes [#324](#324)
@ghost
Copy link

ghost commented Jun 5, 2020

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackcmeyer jackcmeyer jackcmeyer approved these changes

@matteovivona matteovivona matteovivona left review comments

@irvelervel irvelervel Awaiting requested review from irvelervel

Assignees
No one assigned
Labels
in progress released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translation for Calendar component
4 participants
@vicdurai @jsf-clabot @matteovivona @jackcmeyer