Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Translation for Calendar component #324

Closed
martimfj opened this issue Mar 16, 2020 · 5 comments · Fixed by #438
Closed

Translation for Calendar component #324

martimfj opened this issue Mar 16, 2020 · 5 comments · Fixed by #438
Assignees
@vicdurai
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested released

Comments

@martimfj
Copy link

martimfj commented Mar 16, 2020 •
edited
Loading

🚀 Feature Proposal

As stated here the calendar component does not have a way to translate dates and some buttons at the frontend.

Motivation

Improve internationalization and UX.

Example

This could be done by editing how the Calendar in imported. The fullcalendar, which is used in this project, has locales built in. See more on: https://fullcalendar.io/docs/locale
@matteovivona matteovivona added good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested labels Mar 31, 2020
@MatthewDorner
Copy link
Contributor

The DatePicker component we use from react-datepicker accepts a locale prop. If you pass "P" as the dateFormat prop, it will also format the date based on the locale. We just need to register all the locales we're going to use in DateTimePicker.tsx as has already been done for enUS and ptBR.

Hacker0x01/react-datepicker#1580.

datetimepicker

@vicdurai
Copy link
Contributor

Hi, can I pick up this issue?

@matteovivona
Copy link
Contributor

@vicdurai ok!

vicdurai pushed a commit to vicdurai/components that referenced this issue May 25, 2020
feat(datetimepicker.tsx and dropdown.tsx): multiple languages, onClick
ab390db 
Added support for multiple languages (supported by the UI at the time of writing) for
DateTimePicker. Added story to demonstrate new languages. Also added support for onClick in
dropdown.)

fix HospitalRun#324
@vicdurai vicdurai mentioned this issue May 25, 2020
Merged
@vicdurai
Copy link
Contributor

Pull request #438 is ready for review. Having some issues with signing the CLA agreement.

ghost pushed a commit that referenced this issue Jun 5, 2020
@semantic-release-bot
chore(release): 1.12.0 [skip ci]
1d44af2 
# [1.12.0](v1.11.0...v1.12.0) (2020-06-05)

### Features

* **datetimepicker, dropdown:** support all languages ([8e42796](8e42796)), closes [#438](#438)
* **datetimepicker.tsx and dropdown.tsx:** multiple languages, onClick ([ab390db](ab390db)), closes [#324](#324)
@ghost
Copy link

ghost commented Jun 5, 2020

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vicdurai vicdurai

Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(datetimepicker): add support for multiple languages vicdurai/components
4 participants
@matteovivona @vicdurai @martimfj @MatthewDorner