Beautify and Multi-root Workspaces #178
Comments
|
Hey Sean,
I haven’t worked on it for while, but I’ll have a glance over it today. Is the builtin formatter still using js-beautify? If it is, it would be easy to roll this extension in simply by parsing the resource files (`.jsbeautifyrc` and `.editorconfig`) as well as the vs-code settings.
Cheers,
Hooky
… On 14/10/2017, at 05:00, Sean McBreen ***@***.***> wrote:
Hi,
I'm from the VS Code team and I'm reaching out with some additional resources for adopting multi-root workspaces.
But first let me say thank you for working on and maintaining Beautify for VS Code <https://marketplace.visualstudio.com/items?itemName=HookyQR.beautify> which is one of the most popular extensions, we really appreciate the work you have done to make VS Code better.
The purpose of this issue is that we are very close to releasing a significant new feature for VS Code - Multi-root Workspaces - which is the most requested <https://github.com/Microsoft/vscode/issaues?q=is%3Aopen+is%3Aissue+label%3Afeature-request+sort%3Areactions-%2B1-desc> missing feature. If you have not heard of multi-root workspaces we have described this in several of our recent updates <https://code.visualstudio.com/updates/v1_17#_preview-multi-root-workspaces>. Today it's only enabled in our insiders release but our intent is to enable it for all users in our next update <microsoft/vscode#35875>, targeted for release in the first week of November.
This is a pretty significant change and over the last four months we have updated pretty much all of VS Code to be Multi-root aware as well as updated all of our own extensions. In the process of doing this we have created a set of guidelines for Extension Authors <https://github.com/Microsoft/vscode/wiki/Extension-Authoring:-Adopting-Multi-Root-Workspace-APIs> to follow to ensure their extension can fully leverage the awesomeness that is Multi-root workspaces.
Our Request:
Having looked at your extension we think changes are required in how you:
Make use of the (now deprecated) workspace.rootPath property, there is a proposed migration path and sample for this case.
Contribute or change settings, specifically you need to review whether some of the settings can be applied on a resource (= file location) level instead of being global (= workspace level).
How Can We Help/Resources:
We realize we are asking for your help here - our goal is to make sure that your extensions works well with multi-root and continues to be loved by the community. The guide above outlines the changes that are required <https://github.com/Microsoft/vscode/wiki/Extension-Authoring:-Adopting-Multi-Root-Workspace-APIs> and we have a samples <https://github.com/Microsoft/vscode/wiki/Extension-Authoring:-Adopting-Multi-Root-Workspace-APIs#samples> as well.
But we are sure you will have questions and we thought one way we could look to help is by getting a number of the team members (myself included) to be ready to respond to questions on a Slack Channel that we will dedicate to this issue. To join that channel simply follow this link <https://vscode-dev-community.slack.com/join/shared_invite/enQtMjIxOTgxNDE3NzM0LWU5M2ZiZDU1YjBlMzdlZjA2YjBjYzRhYTM5NTgzMTAxMjdiNWU0ZmQzYWI3MWU5N2Q1YjBiYmQ4MzY0NDE1MzY>.
Again thank you for being part of the VS Code community - we appreciate everything you have done. With the release of Multi-root Workspaces we will be shipping our most requested feature, together we can really help this feature light up for users.
Happy Coding!
Sean McBreen
// cc @bpasero <https://github.com/bpasero> @jrieken <https://github.com/jrieken>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#178>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANsCrHwgAiIvV43OMGe0unnWCcaxE-foks5sr4kugaJpZM4P4tHe>.
|
|
Hi, Unfortunately, we don't use JS-Beautify internally so a mitigation probably would not work/make sense for most users. Several of the team have been on the slack channel answering question so if any crop up that's a good place for a quick response. Sean |
|
Cheers Sean,
Have a good one.
… On 14/10/2017, at 11:13, Sean McBreen ***@***.***> wrote:
Hi,
Unfortunately, we don't use JS-Beautify internally so a mitigation probably would not work/make sense for most users. Several of the team have been on the slack channel answering question so if any crop up that's a good place for a quick response.
Sean
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#178 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANsCrIj_cbPP4tiNIElq6E5HavHNQKchks5sr-CggaJpZM4P4tHe>.
|
|
Request: if you have prepared your extension for Multi-root Workspaces we would love you to add multi-root ready to your This will help us keep track of adoptions and also help users know which extensions have been fully tested. Remember we are here to help should you need it on the Slack channel. Happy Coding |
|
Is there any plans to have Beautify work with Multi-root workspaces? |
|
I intend to work on this sometime this month. I have other projects that are taking priority at the moment. Feel free to submit a pull request. |
|
Hey @seanmcbreen, I dun it. Was real easy in the end. Too many projects, too little time... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I'm from the VS Code team and I'm reaching out with some additional resources for adopting multi-root workspaces.
But first let me say thank you for working on and maintaining Beautify for VS Code which is one of the most popular extensions, we really appreciate the work you have done to make VS Code better.
The purpose of this issue is that we are very close to releasing a significant new feature for VS Code - Multi-root Workspaces - which is the most requested missing feature. If you have not heard of multi-root workspaces we have described this in several of our recent updates. Today it's only enabled in our insiders release but our intent is to enable it for all users in our next update, targeted for release in the first week of November.
This is a pretty significant change and over the last four months we have updated pretty much all of VS Code to be Multi-root aware as well as updated all of our own extensions. In the process of doing this we have created a set of guidelines for Extension Authors to follow to ensure their extension can fully leverage the awesomeness that is Multi-root workspaces.
Our Request:
Having looked at your extension we think changes are required in how you:
workspace.rootPathproperty, there is a proposed migration path and sample for this case.How Can We Help/Resources:
We realize we are asking for your help here - our goal is to make sure that your extensions works well with multi-root and continues to be loved by the community. The guide above outlines the changes that are required and we have a samples as well.
But we are sure you will have questions and we thought one way we could look to help is by getting a number of the team members (myself included) to be ready to respond to questions on a Slack Channel that we will dedicate to this issue. To join that channel simply follow this link.
Again thank you for being part of the VS Code community - we appreciate everything you have done. With the release of Multi-root Workspaces we will be shipping our most requested feature, together we can really help this feature light up for users.
Happy Coding!
Sean McBreen
// cc @bpasero @jrieken
The text was updated successfully, but these errors were encountered: