Ignore duplicate rpaths in #change_rpath

[carlocab]

This causes a deviation in behaviour from install_name_tool, which
will happily change an existing rpath to one that already exists.

Closes #436.

[carlocab]

Even the existing test that I've just deleted seems to differ from install_name_tool's behaviour:

❯ otool -l libdupes.dylib | rg -A2 LC_RPATH
          cmd LC_RPATH
      cmdsize 24
         path dupe (offset 12)
❯ install_name_tool -rpath dupe dupe libdupes.dylib
❯ echo $?
0

[woodruffw]

Hmm, I wonder if install_name_tool's behavior changed beneath us. It wouldn't be the first time...

[carlocab]

I was wondering that too! But I don't have access to an old Mac to check.

[woodruffw]

Neither do I anymore, unfortunately. I remember we did quite a bit of behavioral testing against install_name_tool during the initial development here, so it wouldn't surprise me if things have changed. But we'll continue our policy of roughly following those changes 🙂

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[carlocab]

Have you had the chance to think about how you want to handle this, @woodruffw?

[woodruffw]

Sorry for the delay!

And yeah: I think I agree that this change is for the best.

[carlocab]

No apologies necessary, and thanks!