Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

pkt2flow 1.2 #49492

Closed
wants to merge 3 commits into from
Closed

pkt2flow 1.2 #49492

wants to merge 3 commits into from

Conversation

larseggert
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

You can erase any parts of this template not applicable to your Pull Request.

New Formulae Submissions:

  • Does your submission pass
    brew audit --strict --online <formula> (where <formula> is the name of the formula you're submitting)?
  • Have you built your formula locally prior to submission with brew install <formula>?

Changes to Homebrew's Core:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable? Here's an example if you'd like one.
  • Have you successfully ran brew tests with your changes locally?

depends_on "scons" => :build

def install
"scons"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be unquoted (we have a custom method for running scons).

@dunn
Copy link
Contributor

dunn commented Feb 24, 2016

This is failing our notability audit:

==> audit problems
pkt2flow:
 * GitHub repository not notable enough (<20 forks, <20 watchers and <50 stars)

We only waive that requirement for established projects that move to GitHub or in other exceptional circumstances.

@DomT4
Copy link
Member

DomT4 commented Mar 11, 2016

Passing on this until it meets our eligibility guidelines I'm afraid. If you wish to support it yourself up to that point it's very easy to support formulae in your own tap and there are some tips on doing that here if interested.

Apologies we can't accept this for now, but thank you for the submission to Homebrew nonetheless.

@DomT4 DomT4 closed this Mar 11, 2016
@larseggert
Copy link
Contributor Author

In case anyone is looking, I put this into my own tap for now: https://github.com/larseggert/homebrew-mytap

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants