Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

update 2.3.0 walkmod #49416

Closed
wants to merge 1 commit into from
Closed

update 2.3.0 walkmod #49416

wants to merge 1 commit into from

Conversation

rpau
Copy link
Contributor

@rpau rpau commented Feb 22, 2016

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

You can erase any parts of this template not applicable to your Pull Request.

New Formulae Submissions:

  • Does your submission pass
    brew audit --strict --online <formula> (where <formula> is the name of the formula you're submitting)?
  • Have you built your formula locally prior to submission with brew install <formula>?

Changes to Homebrew's Core:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable? Here's an example if you'd like one.
  • Have you successfully ran brew tests with your changes locally?

@rpau
Copy link
Contributor Author

rpau commented Feb 22, 2016

Excuse me, but I don't understand why the test fails for:

$ export OSX=10.9
$ export HOMEBREW_RUBY=1.8.7

when the system is installing the mime-types, appears the following message:

An error occurred while installing mime-types (1.25.1), and Bundler cannot
continue.
Make sure that gem install mime-types -v '1.25.1' succeeds before bundling.
/Users/travis/.gem/ruby/1.8/gems/bundler-1.11.2/lib/bundler/spec_set.rb:94:in `materialize': Could not find mime-types-1.25.1 in any of the sources (Bundler::GemNotFound)

I am not referencing the mime-types and my test only executes:
system "git", "clone", "--depth", "1", "https://github.com/walkmod/walkmod-core.git"
cd "walkmod-core"
system bin/"walkmod", "check"

@MikeMcQuaid
Copy link
Member

As long as default passes: it's OK.

@MikeMcQuaid
Copy link
Member

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

For future reference the preferred commit message format for simple version updates is walkmod 2.3.0.

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants