This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
GitDownloadStrategy optimization #11976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: The problem I reported below has been solved in the issue listed. I pulled this and tried it using But the llvm formula must still be broken, because I get the same problem I brought up in #10893. I went ahead and made a gist of the terminal output so you could see it cloning and the error. I'll solve this over in that issue. |
The current series of fetch invocations in GitDownloadStrategy has the unfortunate behavior of fetching full history even in shallow clones that only need the history between the clone point and the remote HEAD. It should be possible to determine if it is actually necessary to fetch the full history, including all tags, and if it is not to avoid this overhead. Fixes #11958, and several other recurring problems. Signed-off-by: Jack Nagel <[email protected]>
|
As this is a bugfix, I'm going to merge it in a bit unless there are objections. |
|
Be my guest. |
|
Pushed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current series of fetch invocations in GitDownloadStrategy has the unfortunate behavior of fetching full history even in shallow clones that only need the history between the clone point and the remote HEAD. It should be possible to determine if it is actually necessary to fetch the full history, including all tags, and if it is not to avoid this overhead.
This fixes #11958, and using
:revision(previously:sha) should always clone with full depth; tags and branches are shallow cloned when possible.I'd like to make
host_supports_depth?smart enough to query the remote and determine if shallow clones are supported; right now we can only assume shallow clones are possible when using the git protocol or GitHub HTTP/S.I tested 15-20 git checkouts, but please test any problematic formulae that you know of.