Skip to content
This repository was archived by the owner on Sep 26, 2025. It is now read-only.

lib/tests/formulae: install ca-certificates if needed#672

Merged
carlocab merged 1 commit intoHomebrew:masterfrom
carlocab:install-cacerts
Oct 4, 2021
Merged

lib/tests/formulae: install ca-certificates if needed#672
carlocab merged 1 commit intoHomebrew:masterfrom
carlocab:install-cacerts

Conversation

@carlocab
Copy link
Copy Markdown
Member

@carlocab carlocab commented Oct 4, 2021

This is needed to fix Homebrew/core CI. See Homebrew/brew#12167.

@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented Oct 4, 2021

Just for extra context, we need this to fix SSL cert errors like this one from Homebrew/homebrew-core#86321, since we reverted 28bed81 in b6de336.

Copy link
Copy Markdown
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this being done by the brew install ca-certificates line in update.sh?

@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented Oct 4, 2021

Why isn't this being done by the brew install ca-certificates line in update.sh?

test-bot never actually runs brew update, I think.

@carlocab carlocab merged commit 9743d87 into Homebrew:master Oct 4, 2021
@carlocab carlocab deleted the install-cacerts branch October 4, 2021 06:33
@Rylan12
Copy link
Copy Markdown
Member

Rylan12 commented Oct 4, 2021

Thanks, @carlocab!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants