-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet 6.0.102 #95339
dotnet 6.0.102 #95339
Conversation
inreplace Dir["src/installer.*/src/redist/targets/GenerateLayout.targets"].first, | ||
"$(MicrosoftAspNetCoreAppRuntimePackageVersion)", | ||
"$(MicrosoftAspNetCoreAppRuntimewinx64PackageVersion)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merge, main thing to check upstream is why MicrosoftAspNetCoreAppRuntimePackageVersion
is using 6.0.0 and failing.
MicrosoftAspNetCoreAppRuntimewinx64PackageVersion
is set to 6.0.2 and it looks like build is supposed to use MicrosoftAspNetCoreAppRuntimePackageVersion = MicrosoftAspNetCoreAppRuntimewinx64PackageVersion
I think this can be merged as is for now. I created upstream issue dotnet/source-build#2795 to track our patches/workarounds and find out how to fix upstream. Only odd thing is new workaround where I believe the values are supposed to be the same based on https://github.com/dotnet/installer/blob/v6.0.102-source-build/eng/Versions.props#L86-L93
|
Fine for me. Did the just released 6.0.103 change anything? (6.0.201 isn't yet supported for source build) |
I didn't take a look at release notes yet. I had problems building locally where build stalled. May try again or just run on CI. The |
(For future reference of why 6.0.201 won't work: https://github.com/dotnet/source-build#support) |
🤖 A scheduled task has triggered a merge. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Re-attempting v6.0.102. Originally tried in #92991 but hit some issues.
do not merge
as need to check with upstream on workaround added.Odd tag name due to: dotnet/source-build#2761