-
-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opensearch-dashboards 1.2.0 #90403
opensearch-dashboards 1.2.0 #90403
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
15e1b4b
to
5382eec
Compare
481acd9
to
6c67d67
Compare
Formula/opensearch-dashboards.rb
Outdated
resource "yarn" do | ||
url "https://registry.npmjs.org/yarn/-/yarn-1.22.17.tgz" | ||
sha256 "267982c61119a055ba2b23d9cf90b02d3d16c202c03cb0c3a53b9633eae37249" | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this the same as the yarn
formula?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, wait. That yarn
uses node
. Maybe it'll just work? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right, probably I should move up this comment from the bottom 🙂
# We can't depend on yarn formula since it brings the latest node # (which is getting picked up by some of the scripts and causes build failures) # Repalce with `depends_on "yarn" => :build` when migraded to the latest node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, found this, yarnpkg/website#913 (comment)
arguing about this with Homebrew maintainers
This has already been done countless times, all linked throughout this thread
Yarn can be installed without node, but underlyingly, yarn does need node though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, interesting. I opened #90839, in case that's something we want to consider doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might also be interested about this nodejs TSC discussion, nodejs/TSC#1012
Basically moving forward, nodejs would have corepack serve as abstraction to talk to nodejs package manager like npm
, yarn
, pnpm
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I switched it back to yarn
dependency.
Also, it seems we don't need python
to build the formula.
6c67d67
to
b4f5288
Compare
Yarn can be used with multiple versions of Node, but depending on `node` specifically breaks that. This change allows `yarn` to be used as a dependency for `opensearch-dashboards` (cf. Homebrew#90403). See also yarnpkg/website#913. While we're here, let's adjust the `NPM_CONFIG_PYTHON` value, since the `node` formula doesn't even depend on a Python3 formula at runtime anymore (and it's not that picky about the Python3 version anyway).
b4f5288
to
0c69e5f
Compare
Yarn can be used with multiple versions of Node, but depending on `node` specifically breaks that. This change allows `yarn` to be used as a dependency for `opensearch-dashboards` (cf. #90403). See also yarnpkg/website#913. While we're here, let's adjust the `NPM_CONFIG_PYTHON` value, since the `node` formula doesn't even depend on a Python3 formula at runtime anymore (and it's not that picky about the Python3 version anyway). Closes #90839. Signed-off-by: Sean Molenaar <[email protected]> Signed-off-by: BrewTestBot <[email protected]>
0c69e5f
to
400fe18
Compare
🤖 A scheduled task has triggered a merge. |
Created with
brew bump-formula-pr
.