Skip to content

kyma-cli: fix checksum mismatch, update head branch, and ldflags#88858

Closed
chenrui333 wants to merge 1 commit intoHomebrew:masterfrom
chenrui333:kyma-cli-fix-checksum-mismatch
Closed

kyma-cli: fix checksum mismatch, update head branch, and ldflags#88858
chenrui333 wants to merge 1 commit intoHomebrew:masterfrom
chenrui333:kyma-cli-fix-checksum-mismatch

Conversation

@chenrui333
Copy link
Copy Markdown
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

relates to #88329

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added audit failure CI fails while auditing the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Nov 5, 2021
@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Nov 5, 2021
@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Nov 5, 2021
homepage "https://kyma-project.io"
url "https://github.com/kyma-project/cli/archive/1.24.7.tar.gz"
sha256 "c2465d50f0f2c082fc9bc73ccfac4be824cc826980ab263b8b4ce00dcdcc5b9f"
sha256 "61dcec274376227c8130b2fd6106c5231f878d949f85972182dadacc0396e460"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure where did you get this checksum. I just checked the checksums.txt in the kyma cli release 1.24.7: https://github.com/kyma-project/cli/releases/tag/1.24.7 here the checksum for darwin is different 6cf1e17fb2856adc6d6d18b4e111ca5b495a4722bc8a2750995c930332941b1b.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 1.24.7.tar.gz, not kyma_Darwin_x86_64.tar.gz.

We do not use pre-built binaries in homebrew-core.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

license "Apache-2.0"
head "https://github.com/kyma-project/cli.git"
revision 1
head "https://github.com/kyma-project/cli.git", branch: "main"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious what does the head and branch signify here.

Copy link
Copy Markdown
Member

@Bo98 Bo98 Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git repo and branch to use if someone were to run brew install --HEAD kyma-cli, which takes the latest commit rather than a released tag.

We don't actively CI test this scenario though, so it's very much YMMV.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@chenrui333
Copy link
Copy Markdown
Member Author

chenrui333 commented Nov 16, 2021

@chenrui333 chenrui333 closed this Nov 16, 2021
@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Nov 16, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2021
@chenrui333 chenrui333 deleted the kyma-cli-fix-checksum-mismatch branch December 18, 2022 06:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

audit failure CI fails while auditing the software CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. go Go use is a significant feature of the PR or issue outdated PR was locked due to age superseded PR was replaced by another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants