go 1.17.3

[chenrui333]

Created with brew bump-formula-pr.

resource blocks may require updates.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

[jidicula]

Should this be reopened?

[GwynethLlewelyn]

Should this be reopened?

Most definitely; we need the newest Go version ;)

[SMillerDev]

Most definitely; we need the newest Go version ;)

Let me know if you need anyone to review the PRs for the build failures

[helloPiers]

Hi - I'm just a homebrew user (albeit a Patreon contributing one). I don't really understand the way things are done, or if 6 days is long to wait for a point release - but the failures above (edit: they're below now!) look like timeouts? They're all failed between 391 and 2136 minutes.

[SMillerDev]

Well, nobody seems to have time to investigate and fix them. So nothing is happening. If you want to help you can check if these things also fail when you run the command on your own device (with the older Go)

[chloe-zen]

after hand-editing to 1.17.3 it worked fine for me

maybe just kick off the test again?

[andig]

Please restart CI.

[SMillerDev]

I think only one formula was fixed so that wouldn't help much

[patrickhoefler]

Here's a quick overview of all the (Intel-based) CI steps that are currently failing:

• brew fetch --build-from-source --retry bosh-cli

SHA256: 0525115cdb07915321f478ff61ec6ba28971b0fbac2e8ffb0b6a5fcea12ea322
Warning: Formula reports different sha256: fd45680cff13b2f6a9955d10125ec56fc2a0419c2f224842c528286ff253dd81

• brew fetch --build-from-source --retry kyma-cli fixed with kyma-cli 1.24.8 #89370
• brew install --build-from-source envoy@1.18 probably same cause as in bazel: fix macOS build envoyproxy/envoy#18920 (related to macOS 12 Monterey), not sure if/when this will be fixed
• brew install --build-from-source hasura-cli: Error! No available node version satisfies 'node17'
• brew install --build-from-source ship build error related to Node.js, ship project seems inactive, superseded by kots
• brew test --retry --verbose envoy probably fixed in bazel: fix macOS build envoyproxy/envoy#18920 (related to macOS 12 Monterey), but no new release yet
• brew test --retry --verbose envoy@1.18 pre-existing issue: immediately dies with a segmentation fault on macOS 12 Monterey
• brew test --retry --verbose func-e pre-existing issue: fails as a result of the envoy segmentation fault on macOS 12 Monterey
• brew test --retry --verbose goproxy goproxy: fix test #89377
• brew test --retry --verbose nats-server nats-server: fix test #89168
• brew test --retry --verbose nats-streaming-server nats-streaming-server: fix test #89339
• brew test --retry --verbose termshark termshark: fix test #89340
• brew test --retry --verbose vgrep fixed upstream in Fix RegEx for grep type vrothberg/vgrep#162

[patrickhoefler]

Several of the issues mentioned above are still unfixed, but none (including the fixed ones) seem related to the patch release 1.17.3 of Go.

(Full disclosure: I only looked at the Intel-based issues, not the M1/ARM-based ones.)

[iMichka]

I already wrote a few comments above that this pull request is not the right place to continue this discussion and asked that this was moved to https://github.com/Homebrew/discussions/.

It's also a shame that I have to remember you all our code of conduct: https://github.com/Homebrew/.github/blob/HEAD/CODE_OF_CONDUCT.md#code-of-conduct

I locked the comments here, only maintainers can now write here.

@andig first and last warning: please watch your tone. Thanks

[iMichka]

I re-opened this, as things should have hopefully calmed down. We can now continue on working on fixing the last tests to get this done. If we get the list #88775 (comment) done, we will re-run CI and have a look at what remains to be fixed.

[andig]

Looked into envoy:

 Minitest::Assertion: Expected /envoy +version: [a-f0-9]{40}\/1.20\.[0-9]+\// to match "looking up the latest Envoy version\ndownloading https://archive.tetratelabs.io/envoy/download/v1.20.0/envoy-v1.20.0-darwin-amd64.tar.xz\nstarting: /private/tmp/func-e-test-20211109-60020-4g0mc8/.func-

The Minitest assertion is not part of the envoy formula- not sure where that's coming from. Might already be fixed as part of bazel though.

[andig]

ship:

==> Installing ship
==> make VERSION=0.55.0 build-minimal

Last 15 lines from /Users/andig/Library/Logs/Homebrew/ship/01.make:
node-pre-gyp ERR! stack Error: Failed to execute '/opt/homebrew/Cellar/node@14/14.18.1/bin/node /private/tmp/ship-20211117-88286-24ldn8/ship-0.55.0/web/app/node_modules/node-gyp/bin/node-gyp.js configure --fallback-to-build --module=/private/tmp/ship-20211117-88286-24ldn8/ship-0.55.0/web/app/node_modules/fsevents/lib/binding/Release/node-v83-darwin-arm64/fse.node --module_name=fse --module_path=/private/tmp/ship-20211117-88286-24ldn8/ship-0.55.0/web/app/node_modules/fsevents/lib/binding/Release/node-v83-darwin-arm64 --napi_version=8 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v83 --python=/opt/homebrew/opt/python@3.9/bin/python3' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/private/tmp/ship-20211117-88286-24ldn8/ship-0.55.0/web/app/node_modules/fsevents/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:400:28)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:1058:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:293:5)
node-pre-gyp ERR! System Darwin 21.1.0
node-pre-gyp ERR! command \"/opt/homebrew/Cellar/node@14/14.18.1/bin/node\" \"/private/tmp/ship-20211117-88286-24ldn8/ship-0.55.0/web/app/node_modules/fsevents/node_modules/node-pre-gyp/bin/node-pre-gyp\" \"install\" \"--fallback-to-build\"
node-pre-gyp ERR! cwd /private/tmp/ship-20211117-88286-24ldn8/ship-0.55.0/web/app/node_modules/fsevents
node-pre-gyp ERR! node -v v14.18.1
node-pre-gyp ERR! node-pre-gyp -v v0.12.0
node-pre-gyp ERR! not ok
Failed to execute '/opt/homebrew/Cellar/node@14/14.18.1/bin/node /private/tmp/ship-20211117-88286-24ldn8/ship-0.55.0/web/app/node_modules/node-gyp/bin/node-gyp.js configure --fallback-to-build --module=/private/tmp/ship-20211117-88286-24ldn8/ship-0.55.0/web/app/node_modules/fsevents/lib/binding/Release/node-v83-darwin-arm64/fse.node --module_name=fse --module_path=/private/tmp/ship-20211117-88286-24ldn8/ship-0.55.0/web/app/node_modules/fsevents/lib/binding/Release/node-v83-darwin-arm64 --napi_version=8 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v83 --python=/opt/homebrew/opt/python@3.9/bin/python3' (1)"
info This module is OPTIONAL, you can safely ignore this error
make[1]: *** [.state/package] Error 1
make: *** [build-ui] Error 2

READ THIS: https://docs.brew.sh/Troubleshooting

ship looks like a commercial app. I'd suggest to let ship maintainers fix the build if necessary.

[andig]

The hasura message is funny:

❯ brew info ship
ship: stable 0.55.0 (bottled)
Reducing the overhead of maintaining 3rd-party applications in Kubernetes
https://www.replicated.com/ship
Not installed
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/ship.rb
License: Apache-2.0
==> Dependencies
Build: go ✔, node@14 ✔, yarn ✔
==> Analytics
install: 9 (30 days), 28 (90 days), 223 (365 days)
install-on-request: 9 (30 days), 28 (90 days), 223 (365 days)
build-error: 1 (30 days)

~/htdocs/evcc fix/openwb*
❯ brew install --build-from-source hasura-cli
==> Downloading https://github.com/hasura/graphql-engine/archive/v2.0.10.tar.gz
==> Downloading from https://codeload.github.com/hasura/graphql-engine/tar.gz/v2.0.10
## # -#O=-
==> npm install -ddd --build-from-source --cache=/Users/andig/Library/Caches/Homebrew/npm_cache
==> npm run prebuild
==> ./node_modules/.bin/pkg ./build/command.js --output ./bin/cli-ext-hasura -t host
Last 15 lines from /Users/andig/Library/Logs/Homebrew/hasura-cli/03.pkg:
2021-11-17 17:40:37 +0000

./node_modules/.bin/pkg
./build/command.js
--output
./bin/cli-ext-hasura
-t
host

> pkg@5.2.1
> Error! No available node version satisfies 'node17'

It depends on node14, but complains about 17. No idea what to do there.

Apart from those two it might be good time for restarting CI- everything else has direct fixes or might depend on those fixes.

[samford]

Apparently golang.org now redirects to go.dev. We'll want to update related URLs but, considering how long it takes to run CI, I'm not sure if we want to handle it in this PR or in a follow-up.

[SMillerDev]

If you can rebase it while you're at it, I think this PR is due for a rerun.

[samford]

Rebased, updated the related URLs to go.dev, and added branch: "master" to head (to resolve the audit error).

[andig]

As for ship: no feedback on the ticket, latest commit from Jan 21

[GwynethLlewelyn]

Looks good to me...

[andig]

New failures in ARM build, AMD didn't finish:

• akamai
• awsweeper
• func-e
• vgrep

[carlocab]

This is a security release; let's move this along.

[BrewTestBot]

@carlocab has triggered a merge.

[GwynethLlewelyn]

... and now, 1.17.5 is out...