qwt: switch to qt6

[MehdiChinoune]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[carlocab]

Please split your commits so that each commit modifies only one formula:

• One formula per commit; one commit per formula.
• Keep merge commits out of the pull request.

When you do so, please format your commit messages according to Homebrew/core style:

At Homebrew, we like to put the name of the formula up front like so: foobar 7.3 (new formula).

The preferred commit message format for simple version updates is foobar 7.3 and for fixes is foobar: fix flibble matrix..

See the commit style guide referenced in the PR template for more information.

[carlocab]

Does qwtpolar not need to be switched to qt from qt@5 as well?

[MehdiChinoune]

Does qwtpolar not need to be switched to qt from qt@5 as well?

qwtpolar is now part of qwt (6.2.0)

[MehdiChinoune]

#{Formula["qt"].opt_include} reports an incorrect value I/opt/homebrew/opt/qt/lib/QtGui.framework/Versions/5/Headers, it should be I/opt/homebrew/opt/qt/lib/QtGui.framework/Versions/6/Headers

[carlocab]

#{Formula["qt"].opt_include} reports an incorrect value I/opt/homebrew/opt/qt/lib/QtGui.framework/Versions/5/Headers, it should be I/opt/homebrew/opt/qt/lib/QtGui.framework/Versions/6/Headers

Formula["qt"].opt_include evaluates to $HOMEBREW_PREFIX/opt/qt/include, so there is nothing incorrect about the value it reports.

[carlocab]

Does qwtpolar not need to be switched to qt from qt@5 as well?

qwtpolar is now part of qwt (6.2.0)

Then we need to disable it and point users to qwt.

[MehdiChinoune]

Does qwtpolar not need to be switched to qt from qt@5 as well?

qwtpolar is now part of qwt (6.2.0)

Then we need to disable it and point users to qwt.

It is already disabled.

[carlocab]

You also need these changes in gnuradio:

diff --git a/Formula/gnuradio.rb b/Formula/gnuradio.rb
index 88121be3e4..812e09aad9 100644
--- a/Formula/gnuradio.rb
+++ b/Formula/gnuradio.rb
@@ -103,8 +103,8 @@ class Gnuradio < Formula
       -DENABLE_DEFAULT=OFF
       -DPYTHON_EXECUTABLE=#{venv_root}/bin/python
       -DPYTHON_VERSION_MAJOR=3
-      -DQWT_LIBRARIES=#{Formula["qwt"].lib}/qwt.framework/qwt
-      -DQWT_INCLUDE_DIRS=#{Formula["qwt"].lib}/qwt.framework/Headers
+      -DQWT_LIBRARIES=#{Formula["qwt-qt5"].lib}/qwt.framework/qwt
+      -DQWT_INCLUDE_DIRS=#{Formula["qwt-qt5"].lib}/qwt.framework/Headers
       -DCMAKE_PREFIX_PATH=#{Formula["qt@5"].opt_lib}
       -DQT_BINARY_DIR=#{Formula["qt@5"].opt_bin}
       -DENABLE_TESTING=OFF

[MehdiChinoune]

gnuradio couldn't be build with qwt 6.2.0
gnuradio/gnuradio#4956

[scpeters]

I believe any formulae in 3rd-party taps that depend on qwt will be broken when this is merged. To simplify their migration path, I've added an alias for qwt-qt5 formula in #84275 so that 3rd-party taps can change their dependencies to point to qwt-qt5 in advance. They may still be broken when that is merged, but I think there's a chance it will go more smoothly.

[MehdiChinoune]

• Could this pr merged with broken gnuradio?
• Should I backport the fix to gnuradio?
• Should I wait until new release from gnuradio that supports qwt 6.2.0?

[carlocab]

We don't want to merge this with gnuradio broken, but we can backport a fix if one is available.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[MehdiChinoune]

Is there a way to silent that error about qwt-qt5 patch

==> brew audit qwt-qt5 --online --new-formula
==> FAILED
==> Installing 'bundler' gem
qwt-qt5:
  * Formulae should not require patches to build. Patches should be submitted and accepted upstream first.
Error: 1 problem in 1 formula detected

qwt-qt5 formula is a duplicate of the old qwt!

[carlocab]

Unfortunately not. It is inconvenient, though, because it means the dependent tests are skipped.

It might be better to split switching qwt to Qt6 to a separate PR so that its dependents are tested properly. In the meantime we can have a qwt-qt5 (plus formulae that depend on it) that's actually just a duplicate of qwt.

[MehdiChinoune]

Unfortunately not. It is inconvenient, though, because it means the dependent tests are skipped.

It might be better to split switching qwt to Qt6 to a separate PR so that its dependents are tested properly. In the meantime we can have a qwt-qt5 (plus formulae that depend on it) that's actually just a duplicate of qwt.

see #87092

[carlocab]

Great; can you drop those three commits from this one?

[MehdiChinoune]

Great; can you drop those three commits from this one?

I will rebase it after the other pull-request get merged.

[carlocab]

We'll want to run the tests on qwt built with Qt6 before merging #87092, but those tests won't be run if you don't drop the qwt-qt5 commits.

[carlocab]

Ah, right. Forgot about the mixed dependency audit. Sigh, ok. We'll have to wait then.

[carlocab]

Thanks!

[BrewTestBot]

🤖 A scheduled task has triggered a merge.