Skip to content

go@1.16 1.16.7 (new formula)#84073

Closed
carlocab wants to merge 1 commit intoHomebrew:masterfrom
carlocab:go@1.16
Closed

go@1.16 1.16.7 (new formula)#84073
carlocab wants to merge 1 commit intoHomebrew:masterfrom
carlocab:go@1.16

Conversation

@carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

One noteworthy departure from the other versioned go formulae is that
I've used the main Go formula to bootstrap, instead of specifying a
bootstrap resource. This should make the formula simpler (and hopefully
doesn't break anything...).

We do do this with go-boring, and haven't gotten any complaints about
it so far.

@carlocab carlocab added the CI-force-linux [DEPRECATED] Don't pass --skip-unbottled-linux to brew test-bot. label Aug 27, 2021
@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core labels Aug 27, 2021
One noteworthy departure from the other versioned go formulae is that
I've used the main Go formula to bootstrap, instead of specifying a
bootstrap resource. This should make the formula simpler (and hopefully
doesn't break anything...).

We do do this with `go-boring`, and haven't gotten any complaints about
it so far.
@BrewTestBot
Copy link
Contributor

:shipit: @chenrui333 has triggered a merge.

@carlocab carlocab deleted the go@1.16 branch August 27, 2021 05:01
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-force-linux [DEPRECATED] Don't pass --skip-unbottled-linux to brew test-bot. go Go use is a significant feature of the PR or issue legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants