Skip to content

envoy@1.18 1.18.4#83929

Closed
codefromthecrypt wants to merge 1 commit intoHomebrew:masterfrom
codefromthecrypt:update-envoy@1.18.rb-1629865080
Closed

envoy@1.18 1.18.4#83929
codefromthecrypt wants to merge 1 commit intoHomebrew:masterfrom
codefromthecrypt:update-envoy@1.18.rb-1629865080

Conversation

@codefromthecrypt
Copy link
Contributor

@codefromthecrypt codefromthecrypt commented Aug 25, 2021

@BrewTestBot BrewTestBot added formula deprecated Formula deprecated go Go use is a significant feature of the PR or issue legacy Relates to a versioned @ formula no ARM bottle Formula has no ARM bottle labels Aug 25, 2021
@codefromthecrypt codefromthecrypt mentioned this pull request Aug 25, 2021
Closed
@codefromthecrypt
Copy link
Contributor Author

codefromthecrypt commented Aug 25, 2021

weird... same thing here, though on a different os matrix cell cc @ryan

INFO: Analyzed target //source/exe:envoy-static (810 packages loaded, 42835 targets configured).
84
INFO: Found 1 target...
85
[0 / 77] [Prepa] BazelWorkspaceStatusAction stable-status.txt ... (2 actions, 0 running)
86
ERROR: <builtin>: Failed to determine workspace status: Process exited with status 1
87
fatal: not a git repository (or any of the parent directories): .git
88
Target //source/exe:envoy-static failed to build

This was referenced Aug 25, 2021
Closed
Closed
@cho-m
Copy link
Member

cho-m commented Aug 25, 2021

We haven't gotten around to fixing envoy@1.18 build for Linux, so failure is first CI runner that starts building (either 10.15 or 11).

I had only recently bottled envoy on Linux (#82077).

@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 25, 2021
SMillerDev
SMillerDev reviewed Aug 26, 2021
View reviewed changes
carlocab
carlocab previously approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the comment separately.

@BrewTestBot
Copy link
Contributor

BrewTestBot commented Aug 26, 2021

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Contributor

BrewTestBot commented Aug 26, 2021

⚠️ Bottle publish failed.

@BrewTestBot BrewTestBot dismissed carlocab’s stale review August 26, 2021 10:12

bottle publish failed

carlocab
carlocab previously approved these changes Aug 26, 2021
View reviewed changes
@BrewTestBot
Copy link
Contributor

BrewTestBot commented Aug 26, 2021

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Contributor

BrewTestBot commented Aug 26, 2021

⚠️ Bottle publish failed.

@BrewTestBot BrewTestBot dismissed carlocab’s stale review August 26, 2021 11:12

bottle publish failed

@carlocab
Copy link
Member

carlocab commented Aug 26, 2021

...Not sure why this is failing. Let's try it again. Third time's the charm?

@BrewTestBot
Copy link
Contributor

BrewTestBot commented Aug 26, 2021

:shipit: @carlocab has triggered a merge.

@BrewTestBot
Copy link
Contributor

BrewTestBot commented Aug 26, 2021

⚠️ @carlocab bottle publish failed.

@cho-m
Copy link
Member

cho-m commented Aug 26, 2021

May be an issue with permissions on GitHub package. I don't have permissions to see package settings for envoy@1.18 (although I do see them for envoy), so someone else will need to check.

@codefromthecrypt
envoy@1.18 1.18.4
5e20df9 
Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt codefromthecrypt force-pushed the update-envoy@1.18.rb-1629865080 branch from be9cce9 to 5e20df9 Compare August 26, 2021 20:56
carlocab
carlocab approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops; GitHub registered me as the owner because I uploaded this manually when the formula was first added.

I've inherited access settings from Homebrew/core, so this should work for @BrewTestBot now.

@BrewTestBot
Copy link
Contributor

BrewTestBot commented Aug 27, 2021

🤖 A scheduled task has triggered a merge.

@codefromthecrypt codefromthecrypt deleted the update-envoy@1.18.rb-1629865080 branch August 27, 2021 03:07
@codefromthecrypt
Copy link
Contributor Author

codefromthecrypt commented Aug 27, 2021

thanks for the help!

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SMillerDev SMillerDev SMillerDev left review comments

@carlocab carlocab carlocab approved these changes

Assignees

No one assigned

Labels

CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. formula deprecated Formula deprecated go Go use is a significant feature of the PR or issue legacy Relates to a versioned @ formula no ARM bottle Formula has no ARM bottle outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@codefromthecrypt @cho-m @BrewTestBot @carlocab @SMillerDev