Closed
Conversation
BrewTestBot
added
bump-formula-pr
branchv
force-pushed
the
bump-mmctl-5.38.0
branch
from
a173ce5 to
002d178
Compare
branchv
force-pushed
the
bump-mmctl-5.38.0
branch
from
002d178 to
e96b724
Compare
branchv
commented
Aug 23, 2021
Comment on lines
+26
to
+27
| ldflags = "-s -w -X github.com/mattermost/mmctl/commands.BuildHash=#{Utils.git_head}" | ||
| system "go", "build", *std_go_args(ldflags: ldflags), "-mod=vendor" |
Member
Author
There was a problem hiding this comment.
in addition to removing make's indirection, this avoids failing on gofmt errors with go 1.17
Closed
chenrui333
approved these changes
Aug 23, 2021
Contributor
|
🤖 A scheduled task has triggered a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created with
brew bump-formula-pr.