Skip to content

orgalorg: fix test dependency on ssh#83639

Merged
carlocab merged 1 commit intoHomebrew:masterfrom
gordonbondon:orgalorg-fix-test
Aug 20, 2021
Merged

orgalorg: fix test dependency on ssh#83639
carlocab merged 1 commit intoHomebrew:masterfrom
gordonbondon:orgalorg-fix-test

Conversation

@gordonbondon
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Without this change testing of the formula depends on whether SSH_AUTH_SOCK actually points to active ssh-agent, or if you have private ssh key in default path, both can vary depending on OS version or your setup.

Currently, it sometimes fails like this:

==> /usr/local/Cellar/orgalorg/1.1.1/bin/orgalorg -u tester --host=127.0.0.1:56240 -C uptime 2>&1
Error: orgalorg: failed
An exception occurred within a child process:
  Minitest::Assertion: Expected /connecting\ to\ cluster\ failed/ to match "2021-08-17 19:30:43 [FATAL] can't create runner factory\n                            └─ unable to dial to ssh agent socket: /private/tmp/com.apple.launchd.eR353DMPva/Listeners\n                               └─ dial unix /private/tmp/com.apple.launchd.eR353DMPva/Listeners: connect: no such file or directory\n".

Required to unblock #83413

@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Aug 20, 2021
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gordonbondon!

@carlocab carlocab merged commit 61a9b25 into Homebrew:master Aug 20, 2021
@carlocab carlocab mentioned this pull request Aug 20, 2021
@gordonbondon gordonbondon deleted the orgalorg-fix-test branch August 20, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Go use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants