apache-arrow: use ENV.runtime_cpu_detection#80501
Closed
carlocab wants to merge 1 commit intoHomebrew:masterfrom
Closed
apache-arrow: use ENV.runtime_cpu_detection#80501carlocab wants to merge 1 commit intoHomebrew:masterfrom
ENV.runtime_cpu_detection#80501carlocab wants to merge 1 commit intoHomebrew:masterfrom
Conversation
Also, add a `utf8proc` dependency. The build vendors its own otherwise. Closes Homebrew#76537.
Member
Author
|
|
Contributor
Rylan12
reviewed
Jul 5, 2021
|
|
||
| def install | ||
| # https://github.com/Homebrew/homebrew-core/issues/76537 | ||
| ENV.runtime_cpu_detection if Hardware::CPU.intel? |
Member
There was a problem hiding this comment.
@carlocab all ENV.runtime_cpu_detection calls will be gates by an if Hardware::CPU.intel?, right? What happens if you call it on ARM, do things break? I almost wonder if it just makes more sense to make it a no-op on ARM so it doesn't need the if statements
Member
Author
There was a problem hiding this comment.
Not necessarily -- I think it should also be safe (and desirable) to use unconditionally for formulae like openblas. I just don't know of a good way to actually inspect the binary objects to check that it probably does the right thing on ARM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Also, add a
utf8procdependency. The build vendors its own otherwise.Closes #76537
Needs Homebrew/brew#11608 to land in a
brewrelease before merging.