Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node 16.4.1 #80395

Closed
wants to merge 1 commit into from
Closed

node 16.4.1 #80395

wants to merge 1 commit into from

Conversation

derrabus
Copy link
Contributor

@derrabus derrabus commented Jul 1, 2021 •
edited by chenrui333
Loading

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jul 1, 2021
chenrui333
chenrui333 previously approved these changes Jul 1, 2021
View reviewed changes
@derrabus
Copy link
Contributor Author

derrabus commented Jul 1, 2021

I totally forgot about bumping NPM. Thanks. 🙂

@chenrui333
Copy link
Member

no worries :)

carlocab
carlocab reviewed Jul 1, 2021
View reviewed changes
Formula/node.rb Outdated
@@ -32,8 +32,8 @@ class Node < Formula
# We track major/minor from upstream Node releases.
# We will accept *important* npm patch releases when necessary.
resource "npm" do
url "https://registry.npmjs.org/npm/-/npm-7.18.1.tgz"
sha256 "afc22878cdd5d63b298d62abe832ee7fe37795cd8ccb1fe689ad31d28c790b08"
url "https://registry.npmjs.org/npm/-/npm-7.19.0.tgz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the versioned bundled with Node 16.4.1? I don't see it in the changelog.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream did an upgrade in this PR and there is another one going on.

I checked the artifact, and found the npm version is with 7.18.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the preferred way proceeding in here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bump to 7.19.0 is in this commit: nodejs/node@9c85be1 This isn't in the Node 16.4.1 release tag.

Since we use this resource to track the version that comes with Node, per

homebrew-core/Formula/node.rb

Line 32 in aecea0d

# We track major/minor from upstream Node releases.

I think we should revert the change to the resource.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed @chenrui333's commit from the branch.

@carlocab carlocab added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 1, 2021
@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jul 1, 2021
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@derrabus derrabus deleted the bump-node-16.4.1 branch July 2, 2021 05:12
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @chenrui333 @BrewTestBot @carlocab