open-mpi: remove op-avx from enable-mca-no-build
#76619
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `op-avx` flag disables building features that take advantage of AVX
instructions.
Since `open-mpi` is able to detect CPU features at runtime, disabling
this is not necessary, and simply leads to lower performance for users
with newer machines.
See also:
open-mpi/ompi#8306
open-mpi/ompi#8361
SMillerDev
approved these changes
May 4, 2021
Contributor
|
🤖 A scheduled task has triggered a merge. |
Contributor
Contributor
Member
Author
|
oops. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?The
op-avxflag disables building features that take advantage of AVXinstructions.
Since
open-mpiis able to detect CPU features at runtime, disablingthis is not necessary, and simply leads to lower performance for users
with newer machines.
See also open-mpi/ompi#8306, open-mpi/ompi#8361.