Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandwhich support for M1 #75292

Closed
wants to merge 1 commit into from
Closed

Conversation

safwanrahman
Copy link

@safwanrahman safwanrahman commented Apr 16, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added the rust Rust use is a significant feature of the PR or issue label Apr 16, 2021
@SMillerDev
Copy link
Member

You can't add a bottle by just adding a hash. Are you saying it builds successfully from source now? In that case the maintainers can try to create a bottle on CI.

@BrewTestBot
Copy link
Member

@carlocab bottle request for bandwhich failed.

@carlocab
Copy link
Member

Doesn't build on M1. It likely does without passing --locked to cargo install, but we don't want that.

@safwanrahman
Copy link
Author

@carabolic I have run cargo install --locked --path . with the bandwhich source and it works perfectly there! I dont know why it is not building in homebrew! any idea?

@cho-m
Copy link
Member

cho-m commented Apr 17, 2021

error occurred: Command "clang" "-O3" ... "--target=aarch64-apple-darwin" 

Looks like one of the Rust libraries is passing Rust target aarch64-apple-darwin over to Clang, which expects arm64-apple-darwin.

Could be cc: rust-lang/cc-rs#542

cdzombak added a commit to cdzombak/dotfiles that referenced this pull request Apr 18, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label May 9, 2021
@github-actions github-actions bot closed this May 16, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants