Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vowpal-wabbit 8.9.2 #72409

Closed
wants to merge 4 commits into from
Closed

vowpal-wabbit 8.9.2 #72409

wants to merge 4 commits into from

Conversation

lalo
Copy link
Contributor

@lalo lalo commented Mar 3, 2021 •
edited
Loading

Based on #70445

  • 8.9.1 had a bug surfaced by the homebrew tests, so thanks for that. We've fixed it and bump the version to 8.9.2
  • Added license

@lalo lalo mentioned this pull request Mar 3, 2021
Closed
@BrewTestBot BrewTestBot added the no ARM bottle Formula has no ARM bottle label Mar 3, 2021
@lalo lalo changed the title Bump vowpal wabbit 8.9.2 vowpal wabbit 8.9.2 Mar 3, 2021
@lalo lalo changed the title vowpal wabbit 8.9.2 vowpal-wabbit 8.9.2 Mar 3, 2021
carlocab
carlocab approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lalo.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@BrewTestBot
Copy link
Member

❌ @carlocab bottle request for vowpal-wabbit failed.

@lalo
Copy link
Contributor Author

lalo commented Mar 3, 2021

@carlocab looks like some other process failed, not sure why the CI passed and this one failed. What's the main difference between those runs? I do not have a lot of context here.

@carlocab
Copy link
Member

carlocab commented Mar 3, 2021

Fails to build on ARM with error

error: unknown FP unit 'sse'

@lalo
Copy link
Contributor Author

lalo commented Mar 3, 2021 •
edited
Loading

VW doesn't support ARM currently, is there a way to disable it in Brew?

We're working on adding ARM support soon.

@carlocab
Copy link
Member

carlocab commented Mar 3, 2021

It's already disabled; I just started an ARM build to see if it would work. We can wait till you support it. The bottles for Intel macOS are already uploaded.

@lalo lalo mentioned this pull request Mar 3, 2021
Closed
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Apr 3, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
no ARM bottle Formula has no ARM bottle outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lalo @BrewTestBot @carlocab @chenrui333