vitess 8.0.0 (new formula)#66364
vitess 8.0.0 (new formula)#66364ankane wants to merge 1 commit intoHomebrew:masterfrom ankane:vitess
Conversation
BrewTestBot
added
go
Formula/vitess.rb
Outdated
There was a problem hiding this comment.
Are you sure automake is needed?
There was a problem hiding this comment.
Nice catch, was part of the Mac instructions, but looks like it's not needed.
Formula/vitess.rb
Outdated
There was a problem hiding this comment.
If go is used, how are the dependencies/modules handled? Where are their versions specified, are they pinned, etc?
There was a problem hiding this comment.
I'm not super familiar with Go packaging, but looks like go.sum: https://github.com/vitessio/vitess/blob/master/go.sum
There was a problem hiding this comment.
vitess uses go modules, the dependencies are in go.mod
Formula/vitess.rb
Outdated
There was a problem hiding this comment.
Are mysqlctl and vtctl used outside of our tests? If not, they should go into pkgshare as well
There was a problem hiding this comment.
These aren't used in Homebrew tests, but are needed in bin if users want to follow the Getting Started tutorial on the Vitess website.
| sha256 "c47320b9bcb874b1a6dfca78ec677be7c4bb4c7b2a6470df80bd1bc0ad125e92" | ||
| license "Apache-2.0" | ||
|
|
||
| depends_on "go" => :build |
There was a problem hiding this comment.
Seems like it builds fine with the latest version and we don't allow new formula to depend on legacy software.
There was a problem hiding this comment.
@SMillerDev just fyi, go 1.13 isn't legacy, it still receives security updates: https://golang.org/doc/devel/release.html#go1.13.minor
There was a problem hiding this comment.
Until February, meanwhile there have been 2 new releases. It's not deprecated but it is legacy IMHO.
There was a problem hiding this comment.
Building might work, but tests do not pass for newer go versions. It's shameful, but still not done. :(
Vitess is only supported on go@1.13 at the moment (I'm one of the maintainers of Vitess)
There was a problem hiding this comment.
I tend to agree: we can accept this formula when it builds with latest go.
|
Will go ahead and close for now. @systay @deepthi feel free to let me know when Go 1.15 is supported (looks like there's been some work done here: vitessio/vitess#6792). |
|
@ankane the upcoming Vitess 9.0 release will run on golang 1.15. We released 9.0-rc1 yesterday. .https://github.com/vitessio/vitess/releases/tag/v9.0.0-rc1 |
|
@systay great to hear, will be on the lookout for the final release. |
7 participants
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Notes
make installdoesn't installmysqlctlandvtctl, which are needed to run the local examples (called in./101_initial_cluster.sh).make install-localon master installsmysqlctlbut notvtctl(PR to addvtctl: Add vtctl to make install-local vitessio/vitess#7125), so the formula hopefully won't need thebin.installlines in the future.