keepassc: migrate to [email protected] #62341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
python
|
Closed
mitchblank
added a commit
to mitchblank/homebrew-core
that referenced
this pull request
Dec 22, 2020
There was a previous attempt to do this by @fxcoudert (Homebrew#62341) but it didn't work. I did some debugging and found the issue was just that by default pycryptodomex installs into an egg-directory which isn't what we want. Just forcing it to use --single-version-externally-managed (like many other formulae with python subresources do) solves the issue. The kppy subresource doesn't accept this option, but it looks like it installs fine without it.
BrewTestBot
pushed a commit
that referenced
this pull request
Dec 22, 2020
There was a previous attempt to do this by @fxcoudert (#62341) but it didn't work. I did some debugging and found the issue was just that by default pycryptodomex installs into an egg-directory which isn't what we want. Just forcing it to use --single-version-externally-managed (like many other formulae with python subresources do) solves the issue. The kppy subresource doesn't accept this option, but it looks like it installs fine without it. Closes #67406. Signed-off-by: FX Coudert <[email protected]> Signed-off-by: BrewTestBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the Python 3.9 migration (#62201).
This formula is independent from the all other Python formulas (if I didn't screw up my script or my logic)
Do not merge before the next Brew tag ships, expected on Monday 2020-10-12