-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fortune: Don't install offensive quotes #61706
Conversation
- These violate our Code of Conduct.
206f24c
to
c6b4aa7
Compare
I tried to add a license, but I picked the wrong one (oops, I think I read the wrong file), and then the one that it actually is (BSD, for the modified download we ship) is not a recognized license identifier. So I gave up with setting a license for this right now. Either way, licenses aren't the most important thing with this PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @issyl0 ! Without your contributions it'd be impossible to keep homebrew going. You can feel good knowing that you've made the world a lot better for homebrew users around the world! 👍 🎉
@issyl0 has triggered a merge. |
Is there not a way to restore these using the existing formula? I can certainly agree installing them by default for folks who don't want them isn't the right behavior, and I know Homebrew doesn't really have options/arguments to formulas anymore, so does that basically mean to get these back you have to fork the formula? EDIT: seems like no -- I can appreciate these kinds of things are difficult decisions and an effort to be as welcoming as possible, so thanks regardless for doing this. In case anyone else is looking for it, I stuck a version of this formula with the change reverted here. |
@Julian yes, the best way to get this functionality is to host it in your own custom tap (as you've done). I want to take a second to thank you for being so respectful about this. I opened this (hesitantly) expecting an angry comment berating us for making this choice... that's how these often go, unfortunately. Needless to say, I was pleasantly surprised! It can be draining having to handle stubborn commenters telling us we're doing things the wrong way and offering no help. Hearing positive feedback, even on a disappointing change, makes a big difference to us and is what makes being a maintainer worth it. Thank you for your understanding and thanks for the kind words! ❤️ |
I specifically tried to be as understanding as I could, regardless of whether I agreed or not, knowing that'd be the case :) (that you may have been bracing for backlash, and that ultimately there can be nothing but good will intended here by making this kind of change, even if it means a few of us get some extra work if we insist). So yeah thank you again! |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?