Skip to content

Use OS.kernel_version#59902

Merged
SeekingMeaning merged 16 commits intoHomebrew:masterfrom
SeekingMeaning:os-kernel-version
Sep 8, 2020
Merged

Use OS.kernel_version#59902
SeekingMeaning merged 16 commits intoHomebrew:masterfrom
SeekingMeaning:os-kernel-version

Conversation

@SeekingMeaning
Copy link
Contributor

@SeekingMeaning SeekingMeaning commented Aug 19, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Requires next brew release after 2.4.12 (Depends on Homebrew/brew#8381)
Can be merged as of brew version 2.4.13

brew irb:

irb> "#{`uname -r`.to_i}"
=> "19"
irb> "#{OS.kernel_version.major}"
=> "19"
irb> "#{`uname -r`.chomp}"
=> "19.6.0"
irb> "#{OS.kernel_version}"
=> "19.6.0"
irb> Utils.safe_popen_read("uname", "-r").chomp
=> "19.6.0"

@SeekingMeaning SeekingMeaning added do not merge CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Aug 19, 2020
@SeekingMeaning SeekingMeaning self-assigned this Aug 19, 2020
@SeekingMeaning SeekingMeaning removed the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 20, 2020
@SeekingMeaning SeekingMeaning marked this pull request as ready for review August 21, 2020 20:20
Formula/gcc.rb Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

irb(main):001:0> `uname -r`.split(".").first
=> "19"
irb(main):002:0> OS.kernel_version.major
=> #<Version::NumericToken 19>

Copy link
Contributor Author

@SeekingMeaning SeekingMeaning Aug 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

irb(main):001:0> `uname -r`.chomp
=> "19.6.0"
irb(main):002:0> OS.kernel_version
=> #<Version:0x00007fe0c0932828 @version="19.6.0">

Formula/gcc@5.rb Outdated
Copy link
Contributor Author

@SeekingMeaning SeekingMeaning Aug 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See gcc@4.9

Formula/gcc@6.rb Outdated
Copy link
Contributor Author

@SeekingMeaning SeekingMeaning Aug 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See gcc@4.9

Formula/gcc@7.rb Outdated
Copy link
Contributor Author

@SeekingMeaning SeekingMeaning Aug 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See gcc@4.9

Copy link
Contributor Author

@SeekingMeaning SeekingMeaning Aug 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See ghc

Copy link
Contributor Author

@SeekingMeaning SeekingMeaning Aug 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See ghc

Formula/gmp.rb Outdated
Copy link
Contributor Author

@SeekingMeaning SeekingMeaning Aug 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See ghc

Formula/mpir.rb Outdated
Copy link
Contributor Author

@SeekingMeaning SeekingMeaning Aug 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See ghc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

irb(main):007:0> Utils.safe_popen_read("uname", "-r").chomp
=> "19.6.0"
irb(main):008:0> OS.kernel_version
=> #<Version:0x00007fc5f5ad3488 @version="19.6.0", @tokens=[#<Version::NumericToken 19>, #<Version::NumericToken 6>, #<Version::NumericToken 0>]>

@SeekingMeaning
Copy link
Contributor Author

10.15:

Error: 5 failed steps!
brew audit gcc@7 --online --git --skip-style
brew install --build-from-source bond
brew install --build-from-source bup
brew fetch --retry deno
brew test --retry --verbose agda

10.14, 10.13:

Error: 4 failed steps!
brew audit gcc@7 --online --git --skip-style
brew install --build-from-source bup
brew fetch --retry deno
brew test --retry --verbose agda

@SeekingMeaning
Copy link
Contributor Author

@SeekingMeaning SeekingMeaning merged commit d770e2b into Homebrew:master Sep 8, 2020
@SeekingMeaning SeekingMeaning deleted the os-kernel-version branch September 8, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant